test(cluster): split tests between parallel and sequential packages #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddebko
force-pushed
the
ddebko-split-cluster-tests
branch
from
7ed2a5a to
dd35ca1
Compare
moduli
previously approved these changes
Dec 20, 2024
ddebko
force-pushed
the
ddebko-split-cluster-tests
branch
from
90989fb to
796469c
Compare
johanbrandhorst
approved these changes
Dec 20, 2024
moduli
reviewed
Dec 20, 2024
Johan asked me to split the PR into two different PRs. We wanted to validate some smaller changes to test if they would improve stability with tests passing consistently. |
moduli
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are a number of tests in the cluster package that must run sequentially (due to global variables that are being manipulated), but there are also many tests that can run in parallel. The golang sdk does not allow us to configure how we want to run these tests in a specific order. Therefore, I split the tests into two sub packages. This has greatly improved the runtime of the tests, without introducing flaky behaviors.
Before:
After:
