fix(db): Remove begin when assembling migrations #5148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the set of migrations to run as part of executing the
database migrate
ordatabase init
, the migrations are collected andcombined to run within a database transaction. As such the
begin
andcommit
statements in the migration files should get removed from thefinal set of statements that get executed. However, when the migrations
files were updated to include copyright and license headers, this broke
the logic that would strip out the
begin
statement.While this does not cause any issue with executing the statements in a
single transaction, it does result in noise in the database server's
logs, with log messages like:
This commit fixes the logic to correctly strip the
begin
for filesthat have the header lines.