chore(e2e): Use public version of enos #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancragun
reviewed
Jun 4, 2024
moduli
force-pushed
the
moduli-e2e-public-enos
branch
from
438e957 to
fafb276
Compare
moduli
commented
Jun 5, 2024
| @@ -104,7 +104,7 @@ module "aws_target" { | |||
| } | |||
|
|
|||
| module "vault" { | |||
| source = "app.terraform.io/hashicorp-qti/aws-vault/enos" | |||
| source = "./modules/aws_vault" | |||
There was a problem hiding this comment.
For now, I'm going to just copy the contents of the of the shared terraform provider as opposed to updating to use the copy from the vault repo. There have been many a number of changes to this module that exist in the vault repo, so I'd like to save that for a separate activity.
moduli
force-pushed
the
moduli-e2e-public-enos
branch
from
fafb276 to
397da5b
Compare
stasryzhov
approved these changes
Jun 7, 2024
terraform-enos-aws-vault is no longer supported
moduli
force-pushed
the
moduli-e2e-public-enos
branch
from
397da5b to
ab427c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the e2e test suite to utilize the public version of enos. Enos (both the CLI and the Terraform Provider) were moved to public repositories and, as a result, no longer require a user to need a TFC token.
For anyone with an existing setup, you can run the following
Follow-up
enos-run-ent.ymlto remove tfc_api_tokenhttps://hashicorp.atlassian.net/browse/ICU-13987