Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: point to new api & sdk tagged versions #4847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elimt
Copy link
Member

@elimt elimt commented May 30, 2024

No description provided.

@elimt elimt added this to the 0.16.x milestone May 30, 2024
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of api was 0.0.51 made with? I know we recently release 0.0.50 from main.

@elimt
Copy link
Member Author

elimt commented May 30, 2024

What version of api was 0.0.51 made with? I know we recently release 0.0.50 from main.

@johanbrandhorst This was made with 0.16.1

@elimt elimt requested a review from johanbrandhorst June 5, 2024 18:17
@johanbrandhorst
Copy link
Collaborator

johanbrandhorst commented Jun 5, 2024

What version of api was 0.0.51 made with? I know we recently release 0.0.50 from main.

@johanbrandhorst This was made with 0.16.1

Can you check the difference between release 0.0.50 and 0.0.51, if any? I hope we didn't accidentally break any users by removing features. We should be careful about tagging releases on release branches.

@elimt
Copy link
Member Author

elimt commented Jun 5, 2024

Can you check the difference between release 0.0.50 and 0.0.51, if any? I hope we didn't accidentally break any users by removing features. We should be careful about tagging releases on release branches.

Shouldn't API & SDK releases correspond with the changes in our official releases? api/v0.0.50 was made by @talanknight but he added the changes made with that to release/0.16.x. I did a diff between both and did not see anything in api/v0.0.51 that removes features: api/v0.0.50...api/v0.0.51

@elimt elimt modified the milestones: 0.16.x, deferred Jun 10, 2024
@johanbrandhorst
Copy link
Collaborator

Shouldn't API & SDK releases correspond with the changes in our official releases? api/v0.0.50 was made by @talanknight but he added the changes made with that to release/0.16.x. I did a diff between both and did not see anything in api/v0.0.51 that removes features: api/v0.0.50...api/v0.0.51

The api module is released whenever we need it to be. I think the 0.0.50 tag in this case was made from main, but we did backport the changes so indeed there was no harm done here. As long as you checked before making the new tag it's all good, but obviously we definitely don't want to make a 0.0.51 tag with features from 0.0.50 removed (unless we do so intentionally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants