Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(e2e): Clean up UI docker scenario #4843

Merged
merged 2 commits into from
Jun 4, 2024
Merged

chore(e2e): Clean up UI docker scenario #4843

merged 2 commits into from
Jun 4, 2024

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented May 30, 2024

This PR is both a clean up of the UI docker e2e test scenario as well as a follow-up to #4840.

  • This scenario previously set up an extra docker container for a worker in order to generate a worker token. However, I think we need to rethink that approach as a worker token is a one-time use token and we want to run tests on each browser type
  • In the above PR, we added some variables to support an Admin UI MinIO test. One of the variables added was not necessary.

@moduli moduli added pr/no-milestone Ignores the Milestone Check backport/0.16.x labels May 30, 2024
@moduli moduli requested a review from stasryzhov May 30, 2024 13:16
@moduli moduli merged commit 61db074 into main Jun 4, 2024
66 of 68 checks passed
@moduli moduli deleted the moduli-e2e-ui-docker-cleanup branch June 4, 2024 17:03
@hc-github-team-secure-boundary hc-github-team-secure-boundary mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stasryzhov stasryzhov stasryzhov approved these changes

Assignees
No one assigned
Labels
backport/0.16.x pr/no-milestone Ignores the Milestone Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moduli @stasryzhov