Target listing review comments #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
commented
Oct 16, 2023
| rt.LastItemId = res.GetPublicId() | ||
| rt.LastItemUpdatedTime = res.GetUpdateTime().AsTime() | ||
| rt = rt.Refresh(updatedTime) |
There was a problem hiding this comment.
Now that Refresh does more than a trivial amount of work, we call it from here instead of copying the logic
johanbrandhorst
commented
Oct 16, 2023
Comment on lines
+10
to
+12
| ListDeletedIds = (*Repository).listDeletedIds | ||
| EstimatedCount = (*Repository).estimatedCount | ||
| ListTargets = (*Repository).listTargets |
johanbrandhorst
commented
Oct 16, 2023
johanbrandhorst
commented
Oct 16, 2023
johanbrandhorst
commented
Oct 16, 2023
| addr := target.TestNewTargetAddress(id, opts.WithAddress) | ||
| err := rw.Create(ctx, addr) | ||
| require.NoError(err) | ||
| } |
There was a problem hiding this comment.
Had to add this to support the WithAddress option to targettest.
johanbrandhorst
commented
Oct 16, 2023
| for _, tar := range got { | ||
| assert.Equal(t, "1.2.3.4", tar.GetAddress()) | ||
| } | ||
| } |
There was a problem hiding this comment.
These tests were all moved to the target package mostly unchanged
mikemountain
approved these changes
Oct 16, 2023
tmessi
reviewed
Oct 16, 2023
johanbrandhorst
force-pushed
the
jbrandhorst-targets-review-comments
branch
from
a6d9230 to
7325ef8
Compare
This also adds back the testing of ListDeletedIds and EstimatedCount using the pattern of exporting internal methods to test files only.
Renames all external test files to use the `_ext_test.go` name pattern, making it clear which tests have access to internals of the package and which do not.
johanbrandhorst
force-pushed
the
jbrandhorst-targets-review-comments
branch
from
7325ef8 to
fb6af37
Compare
This doesn't actually match any Postgres setting we configure.
tmessi
reviewed
Oct 17, 2023
Comment on lines
84
to
85
| // Refresh refreshes a token's updated time. It accounts for database | ||
| // transaction inaccuracies by subtracting UpdatedTimeBuffer from the |
There was a problem hiding this comment.
I don't think "inaccuracies" is the right word here. It is the nature of a MVCC. There may have been items that have an older update time than updatedTime that where not visible at the time updatedTime was returned.
There was a problem hiding this comment.
Reworded this slightly, please take a look.
tmessi
approved these changes
Oct 17, 2023
johanbrandhorst
added a commit
that referenced
this pull request
Oct 23, 2023
* refreshtoken: handle database buffer * internal/target: unexport ListTargets This also adds back the testing of ListDeletedIds and EstimatedCount using the pattern of exporting internal methods to test files only. * internal/target: rename external test files Renames all external test files to use the `_ext_test.go` name pattern, making it clear which tests have access to internals of the package and which do not. * internal/refreshtoken: remove Postgres timeout reference This doesn't actually match any Postgres setting we configure. * Reword buffer comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refreshtoken: handle database buffer
internal/target: unexport ListTargets
This also adds back the testing of ListDeletedIds and EstimatedCount using the pattern of exporting internal methods to test files only.