internal/daemon: simplify time update tests

Using time.After makes the intent clearer
hashicorp · Aug 23, 2024 · a8cc893 · a8cc893
1 parent bf52575
commit a8cc893
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/internal/daemon/controller/testing.go b/internal/daemon/controller/testing.go
@@ -941,7 +941,7 @@ func (tc *TestController) WaitForNextWorkerStatusUpdate(workerStatusName string)
 			break
 		}
 
-		if waitStatusCurrent.Sub(waitStatusStart) > 0 {
+		if waitStatusCurrent.After(waitStatusStart) {
 			break
 		}
 	}

diff --git a/internal/daemon/worker/status.go b/internal/daemon/worker/status.go
@@ -110,7 +110,7 @@ func (w *Worker) WaitForNextSuccessfulStatusUpdate() error {
 			return ctx.Err()
 		}
 
-		if w.lastSuccessfulStatusTime().Sub(waitStatusStart) > 0 {
+		if w.lastSuccessfulStatusTime().After(waitStatusStart) {
 			break
 		}
 	}

diff --git a/internal/daemon/worker/worker.go b/internal/daemon/worker/worker.go
@@ -715,7 +715,7 @@ func (w *Worker) Shutdown() error {
 			break
 		}
 
-		if w.lastSuccessfulStatusTime().Sub(waitStatusStart) > 0 {
+		if w.lastSuccessfulStatusTime().After(waitStatusStart) {
 			break
 		}
-Original file line number
+Diff line change
@@ Expand Up @@
     			break
     		}
-    		if waitStatusCurrent.Sub(waitStatusStart) > 0 {
+    		if waitStatusCurrent.After(waitStatusStart) {
     			break
     		}
     	}
@@ Expand Down @@