Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirage cleanup (People route) #639

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Mirage cleanup (People route) #639

merged 1 commit into from
Mar 7, 2024

Conversation

jeffdaley
Copy link
Contributor

  • Removes unused Mirage route (/people, GET)
  • Moves POST route to a new section

@jeffdaley jeffdaley marked this pull request as ready for review March 7, 2024 15:24
@jeffdaley jeffdaley requested a review from a team as a code owner March 7, 2024 15:24
jfreda
jfreda approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh glad to see we're not using the GET method for the people API. I think it's still supported, but we should remove it in the backend.

@jeffdaley jeffdaley merged commit fc81a7d into main Mar 7, 2024
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/rearrange-people branch March 7, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda