Refactor CustomEditableFields (#565)

* Refactor CustomEditableFields * Update custom-editable-field.ts
hashicorp-forge · Jan 26, 2024 · e050d6a · e050d6a
1 parent 6a0afb8
commit e050d6a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/web/app/components/custom-editable-field.hbs b/web/app/components/custom-editable-field.hbs
@@ -1,8 +1,8 @@
 <div class="editable-field-container" ...attributes>
   <EditableField
     data-test-custom-field
-    data-test-custom-field-type={{if this.typeIsString "string" "people"}}
-    @value={{if this.typeIsString this.stringValue this.hermesUsers}}
+    data-test-custom-field-type={{if this.typeIsPeople "people" "string"}}
+    @value={{if this.typeIsPeople this.hermesUsers this.stringValue}}
     @onChange={{if this.typeIsPeople this.onPeopleSelectChange}}
     @onSave={{if this.typeIsPeople this.onPeopleSave @onSave}}
     @isSaving={{@isSaving}}

diff --git a/web/app/components/custom-editable-field.ts b/web/app/components/custom-editable-field.ts
@@ -20,10 +20,10 @@ interface CustomEditableFieldComponentSignature {
 }
 
 export default class CustomEditableFieldComponent extends Component<CustomEditableFieldComponentSignature> {
-  protected get typeIsString() {
-    return this.args.attributes.type === "STRING";
-  }
-
+  /**
+   * Whether type of the field is `PEOPLE`.
+   * Used in the template to determine what to pass to `EditableField`.
+   */
   protected get typeIsPeople() {
     return this.args.attributes.type === "PEOPLE";
   }