Skip to content

Commit

Permalink
pr feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Jeromy Cannon <[email protected]>
  • Loading branch information
jeromy-cannon committed Feb 23, 2024
1 parent 7e87c92 commit 9ce1bfd
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 16 deletions.
1 change: 0 additions & 1 deletion src/commands/account.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export class AccountCommand extends BaseCommand {
this.logger.error(`failed to update account keys for accountId ${ctx.accountInfo.accountId}`)
return false
}
this.logger.silly(`sent account key update for account ${ctx.accountInfo.accountId}`)
} else {
amount = amount || flags.amount.definition.defaultValue
}
Expand Down
2 changes: 1 addition & 1 deletion src/commands/node.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ export class NodeCommand extends BaseCommand {
}
},
{
title: 'Upgrade the network deployment to enable mirror node with the address book',
title: 'Enable mirror node',
task: async (ctx, parentTask) => {
const subTasks = [
{
Expand Down
10 changes: 0 additions & 10 deletions src/core/account_manager.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ export class AccountManager {
let keys
try {
keys = await this.getAccountKeys(accountId, nodeClient)
this.logger.silly(`retrieved keys for account ${accountId.toString()}`)
} catch (e) {
this.logger.error(`failed to get keys for accountId ${accountId.toString()}, e: ${e.toString()}\n ${e.stack}`)
return {
Expand Down Expand Up @@ -334,7 +333,6 @@ export class AccountManager {
value: accountId.toString()
}
}
this.logger.silly(`created k8s secret for account ${accountId.toString()}`)
} catch (e) {
this.logger.error(`failed to create secret for accountId ${accountId.toString()}, e: ${e.toString()}`)
return {
Expand All @@ -353,7 +351,6 @@ export class AccountManager {
value: accountId.toString()
}
}
this.logger.silly(`sent account key update for account ${accountId.toString()}`)
} catch (e) {
this.logger.error(`failed to update account keys for accountId ${accountId.toString()}, e: ${e.toString()}`)
return {
Expand Down Expand Up @@ -410,9 +407,6 @@ export class AccountManager {
* @returns {Promise<boolean>} whether the update was successful
*/
async sendAccountKeyUpdate (accountId, newPrivateKey, nodeClient, oldPrivateKey) {
this.logger.silly(
`Updating account ${accountId.toString()} with new public and private keys`)

if (typeof newPrivateKey === 'string') {
newPrivateKey = PrivateKey.fromStringED25519(newPrivateKey)
}
Expand All @@ -437,9 +431,6 @@ export class AccountManager {
// Request the receipt of the transaction
const receipt = await txResponse.getReceipt(nodeClient)

this.logger.silly(
`The transaction consensus status for update of accountId ${accountId.toString()} is ${receipt.status}`)

return receipt.status === Status.Success
}

Expand Down Expand Up @@ -508,7 +499,6 @@ export class AccountManager {

throw new FullstackTestingError(`failed to create secret for accountId ${accountInfo.accountId.toString()}, keys were sent to log file`)
}
this.logger.silly(`created k8s secret for account ${accountInfo.accountId}`)

return accountInfo
}
Expand Down
4 changes: 0 additions & 4 deletions src/core/logging.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,6 @@ export const Logger = class {
this.winstonLogger.debug(msg, ...args, this.prepMeta())
}

silly (msg, ...args) {
this.winstonLogger.silly(msg, ...args, this.prepMeta())
}

showList (title, items = []) {
this.showUser(chalk.green(`\n *** ${title} ***`))
this.showUser(chalk.green('-------------------------------------------------------------------------------'))
Expand Down

0 comments on commit 9ce1bfd

Please sign in to comment.