Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: implement semantic release process #17440

Open
wants to merge 93 commits into
base: main
Choose a base branch
from

Conversation

andrewb1269hg
Copy link
Contributor

@andrewb1269hg andrewb1269hg commented Jan 18, 2025

Description:
The purpose of this PR is to create two workflows:

increment-next-main-release.yaml will increment the version.txt file to the next minor release (Ex: 0.58.x --> 0.59.0). This will be used when a release is complete and we are working on a new release version.

flow-trigger-release.yaml will apply a version tag using the git-semver tool with appropriate semantic release versioning, trigger our workflows for a release, and generate the release notes in a markdown format.

Related issue(s):

Fixes #14967

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.) - Roger has created documentation about the process we're transitioning to for release process of 0.59 and onwards.
  • Tested (unit, integration, etc.) - Extensively tested. The latest for action results can be found here for incrementing the minor version number. The latest action results can be found here for triggering the official release process.

Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
@andrewb1269hg
Copy link
Contributor Author

Holding on merge until Nathan reviews this PR.

rbarkerSL
rbarkerSL previously approved these changes Jan 31, 2025
.github/workflows/flow-increment-next-main-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-increment-next-main-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-increment-next-main-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-increment-next-main-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-increment-next-main-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-increment-next-main-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-increment-next-main-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-increment-next-main-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-trigger-release.yaml Outdated Show resolved Hide resolved
.github/workflows/flow-trigger-release.yaml Outdated Show resolved Hide resolved
andrewb1269hg and others added 7 commits January 31, 2025 17:04
Co-authored-by: Nathan Klick <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
Co-authored-by: Nathan Klick <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
@andrewb1269hg
Copy link
Contributor Author

@nathanklick I have resolved all comments on this PR and the changes are ready for verification.

I need to run appropriate checks to confirm everything functions as expected with this final version. I will have documentation available here of my full testing process before merging.

@rbarkerSL for awareness ^ please reapprove when you get a chance.

@andrewb1269hg andrewb1269hg force-pushed the 14967-git-semver-test-branch branch from a8ecfbc to 9ae9425 Compare February 1, 2025 00:01
Signed-off-by: Andrew Brandt <[email protected]>
Signed-off-by: Andrew Brandt <[email protected]>
@andrewb1269hg andrewb1269hg force-pushed the 14967-git-semver-test-branch branch from aa13899 to 5332d31 Compare February 1, 2025 00:55
@andrewb1269hg
Copy link
Contributor Author

andrewb1269hg commented Feb 1, 2025

Potential issue identified here:
I applied v0.59.98 at build-00058 tag. I then made a new branch, added a small commit, then applied v0.59.99. This simulates another publish on the release branch. See the attached picture to see what the branching structure looks like when the steps fail.

The semantic release script was then run on the mainline and silently failed. See the linked job here.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: enable semantic release in gh release workflows
3 participants