LocalProvider - close method #2020
Conversation
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2020 +/- ##
===========================================
+ Coverage 76.12% 83.78% +7.65%
===========================================
Files 304 304
Lines 75854 75861 +7
===========================================
+ Hits 57746 63557 +5811
+ Misses 18108 12304 -5804 ☔ View full report in Codecov by Sentry. |
src/LocalProvider.js
Outdated
| this._client._network.close(); | ||
| this._client._mirrorNetwork.close(); | ||
| this._client._isShutdown = true; | ||
| clearTimeout(this._client._timer); |
There was a problem hiding this comment.
Can we just call this._client.close() ?
There was a problem hiding this comment.
Yes, we can. For some reason it didn't work first time but now it's ok.
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
requested review from
SimiHunjan,
ochikov and
petreze
as code owners
Signed-off-by: svetoslav-nikol0v <[email protected]>
|
SonarCloud Quality Gate failed.
|
Description:
Related issue(s):
Fixes #
Notes for reviewer:
The idea is to close client when we have an instance of the Wallet which is using LocalProvider.
Checklist