Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tabs refactoring #1372

Merged
merged 2 commits into from
Sep 23, 2024
Merged

chore: Tabs refactoring #1372

merged 2 commits into from
Sep 23, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Sep 20, 2024

Description:

Integrate the refactoring brought to the Tabs component as part of the work in the branch 00033_search_token_by_name.

@svienot svienot self-assigned this Sep 20, 2024
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.58% 23853 / 30745
🔵 Statements 77.58% 23853 / 30745
🔵 Functions 61.28% 953 / 1555
🔵 Branches 84.51% 4624 / 5471
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Tabs.vue 100% 100% 100% 100%
src/components/allowances/AllowancesSection.vue 70.37% 88.88% 6.25% 70.37% 53, 172-174, 181-197, 199-200, 205-206, 270-277, 280-284, 288-295, 299-308, 312-319, 323-330, 333-335, 338-340, 342-347, 350-353
src/components/contract/ContractByteCodeSection.vue 80.85% 62.96% 14.28% 80.85% 1, 32-33, 141-142, 165-166, 255-256, 268-270, 277-278, 281-282, 285-302, 304-311, 317, 326-333, 337-345, 356, 361, 365
src/components/token/TokensSection.vue 100% 94.11% 100% 100%
src/pages/AccountDetails.vue 49.33% 84.46% 14.28% 49.33% 1, 27, 29-31, 33-35, 37-38, 41-46, 48-71, 73-78, 80-92, 94-98, 101-106, 109-110, 112-115, 117-118, 120-121, 124-126, 128-130, 132-144, 146, 148-154, 156-160, 162-167, 169, 171-174, 176, 178-180, 182-183, 185-189, 191-192, 194-199, 201-205, 207, 210-216, 218, 220-223, 225, 227-230, 232, 234, 236, 238-240, 242-262, 264-270, 272-274, 276-284, 286-287, 412-418, 422, 424, 467-468, 473-474, 491-493
Generated in workflow #1295

Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ericleponner ericleponner merged commit 5bade80 into main Sep 23, 2024
7 of 8 checks passed
@ericleponner ericleponner deleted the tabs-refactoring branch September 23, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants