Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display max automatic token associations #1284

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Aug 20, 2024

Description:

Align display of max_automatic_token_associations property on spec -- currently raw value is displayed.

Related issue(s):

Fixes #1278

Notes for reviewer:

Deploying on staging server.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.23% 24030 / 30715
🔵 Statements 78.23% 24030 / 30715
🔵 Functions 61.62% 954 / 1548
🔵 Branches 84.38% 4572 / 5418
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/AccountDetails.vue 48.66% 83.33% 14.28% 48.66% 1, 27, 29-31, 33-34, 37-42, 44-67, 69-74, 76-88, 90-94, 97-102, 105-106, 108-116, 118-119, 121-122, 125-127, 129-131, 133-145, 147, 149-155, 157-161, 163-168, 170, 172-175, 177, 179-181, 183-184, 186-190, 192-193, 195-200, 202-206, 208, 211-217, 219, 221-224, 226, 228-231, 233, 235, 237-239, 241-261, 263-269, 271-273, 275-283, 285-286, 407-413, 417, 419, 462-463, 468-469, 486-488
src/pages/ContractDetails.vue 100% 94.04% 100% 100%
src/schemas/HederaUtils.ts 62.12% 76% 72.41% 62.12% 47-48, 54-55, 63-64, 71-72, 89-90, 108-109, 119-122, 132-135, 140-141, 183-192, 194-195, 201-202, 245-253, 262-270, 273-281, 330-331, 333-345, 347-348, 350-378, 396-397, 399-410, 412-413
Generated in workflow #1200

@svienot svienot self-assigned this Aug 20, 2024
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@svienot svienot merged commit 84c3b2e into main Aug 20, 2024
9 of 10 checks passed
@svienot svienot deleted the 1278-display-max_automatic_token_associations branch August 20, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display new account property: max_automatic_token_associations
2 participants