Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nft metadata not visible #1275

Merged
merged 10 commits into from
Aug 19, 2024
Merged

fix: nft metadata not visible #1275

merged 10 commits into from
Aug 19, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Aug 19, 2024

Description:

  • Always display the Metadata Details section in NFT details view (collapsed by default).
  • Always display the Raw Metadata property from the NFT.
  • When the metadata content is retrieved, always display the Raw Metadata and Content Location properties, even if user chooses to display the content in raw form.
  • Do not display metadata content properties when None
  • A bit of TokenMetadataAnalyzer refactoring.

Related issue(s):

Fixes #1269

Notes for reviewer:

On staging server.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.21% 24001 / 30685
🔵 Statements 78.21% 24001 / 30685
🔵 Functions 61.6% 953 / 1547
🔵 Branches 84.36% 4566 / 5412
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/token/MetadataSection.vue 97.98% 100% 50% 97.98% 77, 115, 131
src/components/token/TokenMetadataAnalyzer.ts 77.68% 80% 100% 77.68% 101-103, 105, 143-147, 155-162, 164-175, 242-243, 254-255, 271-272, 283-289, 304-305, 307-310, 324-325, 327-330
Generated in workflow #1193

Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@svienot svienot merged commit 415eafe into main Aug 19, 2024
7 of 8 checks passed
@svienot svienot deleted the 1269-nft-metadata-not-displayed branch August 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token (NFT) metadata not visible if not suitable for image render
2 participants