Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TOKENREJECT transaction type #1270

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Aug 16, 2024

Description:

Basic support for TOKENREJECT (i.e type selector, ...)

Related issue(s):

Fixes #1267

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarcloud bot commented Aug 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

github-actions bot commented Aug 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.16% 23950 / 30642
🔵 Statements 78.16% 23950 / 30642
🔵 Functions 61.53% 952 / 1547
🔵 Branches 84.34% 4546 / 5390
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/transaction/TransactionFilterSelect.vue 100% 100% 60% 100%
src/schemas/HederaSchemas.ts 91.97% 64.28% 100% 91.97% 314-315, 734, 861, 864, 880-881, 884-885, 887-890
src/utils/EntityDescriptor.ts 95.65% 57.4% 100% 95.65% 43-44, 119-120
src/utils/TransactionTools.ts 79.67% 64.28% 80% 79.67% 30-32, 36-37, 39-40, 52-53, 65-66, 77-78, 89-90, 95-101, 103-122, 124-133, 135-136, 139, 141-150, 319-320, 332-333, 348-349, 413-415, 418-419
Generated in workflow #1186

Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit 6702474 into main Aug 19, 2024
7 of 8 checks passed
@svienot svienot deleted the 1267-token-reject-tx-type branch August 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the Token Reject transaction type
2 participants