feat: refactor mirrorNodeClient axios transformResponse and fix all unit tests
#3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
2 tasks
natanasow
changed the base branch from
main
to
3367-transaction-with-contract-negative-value-breaks-routes
quiet-node
requested changes
Jan 30, 2025
quiet-node
requested changes
Jan 30, 2025
Base automatically changed from
3367-transaction-with-contract-negative-value-breaks-routes
to
main
January 31, 2025 14:53
# Conflicts: # packages/relay/src/lib/clients/mirrorNodeClient.ts # packages/relay/tests/lib/eth/eth_getLogs.spec.ts
Signed-off-by: nikolay <[email protected]>
|
quiet-node
approved these changes
Jan 31, 2025
konstantinabl
approved these changes
Feb 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3435 +/- ##
==========================================
+ Coverage 85.46% 85.53% +0.07%
==========================================
Files 69 69
Lines 4753 4751 -2
Branches 1059 1059
==========================================
+ Hits 4062 4064 +2
+ Misses 396 394 -2
+ Partials 295 293 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up on #3387 regarding this discussion #3387 (comment).
Related issue(s):
Fixes #3367
Notes for reviewer:
Checklist