Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT Allowances REST API #857

Merged
merged 7 commits into from
Jan 24, 2024
Merged

NFT Allowances REST API #857

merged 7 commits into from
Jan 24, 2024

Conversation

mgoelswirlds
Copy link
Member

@mgoelswirlds mgoelswirlds commented Jan 16, 2024

Description:

This HIP designs Nft Allowances APIs for mirror node.

* Create nft allowance hip

Signed-off-by: Mugdha Goel <[email protected]>

* Apply suggestions from code review

Co-authored-by: Steven Sheehy <[email protected]>
Signed-off-by: Mugdha Goel <[email protected]>

* Addressing PR comments.

Signed-off-by: Mugdha Goel <[email protected]>

* Adding sample responses for owner = true and false.

* Changing non-existent spender.id to account.id

* Correcting the response data order.

* Adding serial level allowance information API.

---------

Signed-off-by: Mugdha Goel <[email protected]>
Co-authored-by: Steven Sheehy <[email protected]>
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 95efb85
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/65aaa8b9f3335b0008fa26d9
😎 Deploy Preview https://deploy-preview-857--hedera-hips.netlify.app/hip/hip-857
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mgoelswirlds and others added 4 commits January 16, 2024 13:11
* Adding discussions to the HIP.

* Adding HIP number



Signed-off-by: Mugdha Goel <[email protected]>
Co-authored-by: Steven Sheehy <[email protected]>
Signed-off-by: Mugdha Goel <[email protected]>
Signed-off-by: Michael Garber <[email protected]>
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
HIP/hip-857.md Outdated Show resolved Hide resolved
Signed-off-by: Mugdha Goel <[email protected]>
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Ashe-Oro Ashe-Oro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! great feature and thank you both :)

@mgarbs mgarbs merged commit c72dcf9 into hashgraph:main Jan 24, 2024
6 checks passed
kimbor pushed a commit to kimbor/hedera-improvement-proposal that referenced this pull request Jun 24, 2024
Signed-off-by: Mugdha Goel <[email protected]>
Signed-off-by: Michael Garber <[email protected]>
Co-authored-by: Steven Sheehy <[email protected]>
Co-authored-by: Michael Garber <[email protected]>
Signed-off-by: Kim Rader <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants