-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFT Allowances REST API #857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create nft allowance hip Signed-off-by: Mugdha Goel <[email protected]> * Apply suggestions from code review Co-authored-by: Steven Sheehy <[email protected]> Signed-off-by: Mugdha Goel <[email protected]> * Addressing PR comments. Signed-off-by: Mugdha Goel <[email protected]> * Adding sample responses for owner = true and false. * Changing non-existent spender.id to account.id * Correcting the response data order. * Adding serial level allowance information API. --------- Signed-off-by: Mugdha Goel <[email protected]> Co-authored-by: Steven Sheehy <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* Adding discussions to the HIP. * Adding HIP number Signed-off-by: Mugdha Goel <[email protected]> Co-authored-by: Steven Sheehy <[email protected]>
Signed-off-by: Mugdha Goel <[email protected]>
Signed-off-by: Mugdha Goel <[email protected]>
Signed-off-by: Michael Garber <[email protected]>
This was referenced Jan 18, 2024
steven-sheehy
requested changes
Jan 18, 2024
Signed-off-by: Mugdha Goel <[email protected]>
Signed-off-by: Mugdha Goel <[email protected]>
steven-sheehy
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ashe-Oro
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! great feature and thank you both :)
kimbor
pushed a commit
to kimbor/hedera-improvement-proposal
that referenced
this pull request
Jun 24, 2024
Signed-off-by: Mugdha Goel <[email protected]> Signed-off-by: Michael Garber <[email protected]> Co-authored-by: Steven Sheehy <[email protected]> Co-authored-by: Michael Garber <[email protected]> Signed-off-by: Kim Rader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This HIP designs Nft Allowances APIs for mirror node.