-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP-991: Introduce generic custom fee limits #1095
Conversation
Removed accept_all_custom_fees flag Some minor improvements Signed-off-by: Michael Heinrichs <[email protected]>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I added one comment to confirm that change was wanted, but everything else looks correct
…a transaction Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @netopyr
Co-authored-by: Steven Sheehy <[email protected]> Signed-off-by: Michael Garber <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Looks good all conversations are resolved! |
Signed-off-by: Michael Heinrichs <[email protected]> Signed-off-by: Xin Li <[email protected]> Signed-off-by: Michael Garber <[email protected]> Co-authored-by: Xin Li <[email protected]> Co-authored-by: Michael Garber <[email protected]> Co-authored-by: Steven Sheehy <[email protected]>
Description:
Moved
max_custom_fee
toTransactionBody
Removed
accept_all_custom_fees
flagSome minor improvements