Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-991: Introduce generic custom fee limits #1095

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Jan 8, 2025

Description:

Moved max_custom_fee to TransactionBody
Removed accept_all_custom_fees flag
Some minor improvements

Removed accept_all_custom_fees flag
Some minor improvements

Signed-off-by: Michael Heinrichs <[email protected]>
@netopyr netopyr requested a review from mgarbs as a code owner January 8, 2025 14:17
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 6f6b1e0
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/679180ab782bf70007d25f14
😎 Deploy Preview https://deploy-preview-1095--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netopyr netopyr changed the title HIP-911: Introduce generic custom fee limits HIP-991: Introduce generic custom fee limits Jan 9, 2025
Copy link
Contributor

@ty-swirldslabs ty-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I added one comment to confirm that change was wanted, but everything else looks correct

HIP/hip-991.md Show resolved Hide resolved
HIP/hip-991.md Show resolved Hide resolved
steven-sheehy
steven-sheehy previously approved these changes Jan 11, 2025
xin-hedera
xin-hedera previously approved these changes Jan 15, 2025
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @netopyr

HIP/hip-991.md Outdated Show resolved Hide resolved
HIP/hip-991.md Outdated Show resolved Hide resolved
Co-authored-by: Steven Sheehy <[email protected]>
Signed-off-by: Michael Garber <[email protected]>
@mgarbs
Copy link
Collaborator

mgarbs commented Jan 22, 2025

Looks good all conversations are resolved!

@mgarbs mgarbs merged commit 00098c5 into main Jan 22, 2025
12 of 13 checks passed
@mgarbs mgarbs deleted the hip-911-generic-custom-fee-limit branch January 22, 2025 23:36
stoyanov-st pushed a commit to stoyanov-st/hedera-improvement-proposal that referenced this pull request Jan 24, 2025
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Michael Garber <[email protected]>
Co-authored-by: Xin Li <[email protected]>
Co-authored-by: Michael Garber <[email protected]>
Co-authored-by: Steven Sheehy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants