Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getnftinfo will return its metadata and creation time (#198) #225

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

arianejasuwienas
Copy link
Contributor

Description:

A call to the getNonFungibleTokenInfo method on the HTS address (0x167) will now correctly populate the "metadata" and "creationTime" fields.

Related issue(s):

Fixes #198

Notes for reviewer:

Until now, these fields were mocked because they were not supported by IERC721 and required a direct implementation.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@arianejasuwienas arianejasuwienas added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jan 30, 2025
@arianejasuwienas arianejasuwienas self-assigned this Jan 30, 2025
@arianejasuwienas arianejasuwienas force-pushed the 198-nft-metada-and-creation-time branch from 7134471 to 012735b Compare January 30, 2025 12:58
@arianejasuwienas arianejasuwienas changed the title feat: getnftinfo will return its metadata and creation time (#164) feat: getnftinfo will return its metadata and creation time (#198) Jan 30, 2025
@arianejasuwienas arianejasuwienas marked this pull request as ready for review January 31, 2025 08:16
@arianejasuwienas arianejasuwienas requested a review from a team as a code owner January 31, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NFT metadata and creation time
1 participant