Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UnrealIRCd config to support 4.x options #144

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update UnrealIRCd config to support 4.x options #144

wants to merge 8 commits into from

Conversation

drGrove
Copy link
Member

@drGrove drGrove commented Oct 4, 2018

No description provided.

@drGrove drGrove mentioned this pull request Oct 4, 2018
Open
@drGrove
Copy link
Member Author

drGrove commented Oct 4, 2018

Needs hashbang/docker-unrealircd#13. I'm also not sure of a good way to test all of this. Any pointers would be appreciated prior to us merging

@RyanSquared
Copy link
Member

@drGrove with testing, you should be able to set up a VM - or even change the Ansible target to your own system - and run the IRCd locally.

@RyanSquared
Copy link
Member

I can't test it myself right now, I'll try to do so over the weekend.

@drGrove
Copy link
Member Author

drGrove commented Oct 4, 2018 via email

@RyanSquared
Copy link
Member

Does ansible have a local runner

ansible-playbook -i localhost, instead of just ansible-playbook, but I'm not entirely sure how well it would work on a user system because we hardcode in some file paths which might not exist (like /home/core)?

@RyanSquared
Copy link
Member

Ansible also has {{ ansible_env.HOME }} which as I understand, means the $HOME var for the current user.

@benharri
Copy link
Member

benharri commented Oct 4, 2018

you could also spin up a lxd or docker container on a stretch image and run it against that

@drGrove
Move to sync, update conf files to 4.x
c4e3ff2 
Move from copy to sync to allow for recursive copy
Update conf files to 4.x
Move to ansbile_env.HOME
@drGrove drGrove requested a review from benharri October 13, 2018 17:24
RyanSquared
RyanSquared reviewed Dec 3, 2018
View reviewed changes
files/anope/services.conf.j2
@@ -1,21 +1,21 @@
define
{
name = "services.host"
value = "services.irc.hashbang.sh"
value = "services.irc.dannygrove.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should define the top level domain (and possibly subdomains) as a variable so we don't have this issue per-deployment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a good idea. This is because I'm testing a bunch of stuff. I'm also now moving towards helm for this stuff, So most of this work is just to make sure i'm using the correct config style.

@RyanSquared RyanSquared changed the title Update config to support 4.x options Update UnrealIRCd config to support 4.x options Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanSquared RyanSquared RyanSquared left review comments

@lrvick lrvick Awaiting requested review from lrvick

@KellerFuchs KellerFuchs Awaiting requested review from KellerFuchs

@benharri benharri Awaiting requested review from benharri

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drGrove @RyanSquared @benharri