Protect iFrame embed to whitelist #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd config whitelist - Update to use Content-Security-Policy: frame-ancestors instead of X-Frame-Options - OPTION requests send origin header which is needed for the special cors headers - Remove old headers - support configurable whitelist
karendolan
force-pushed
the
t/Add-x-frame-origin-header-to-all
branch
from
43ecb98 to
5f099e0
Compare
|
@lbjay @rute-santos FYI the issue with merging this is that we are afraid our videos are iFramed in non-harvard.edu sites and we didn't want to disturb that. It's a policy question whether to adopt this or not. This pull enables us to white-list non-harvard sites so they can embed, but we have to know about them to add then to the whitelist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Leave this pull open in the case that non-Harvard site embed issues become a priority.
Verified whitelist and harvard.edu cases in QA-1420.
I verified local dev localhost whitelist works running local IC.