get car positions from lap chart PDF (fix #19) #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #19
It's very hard to determine the lap of cars from Race History Chart PDF. The PDF ranks cars by their absolute positions. That is, if car A is physically in front of B, A is ranked above B, regardless of whether B is lapped by A or not. When we have both lapped cars and cars in pit, it's hard to tell if a car is lapped, and thus we cannot assign the correct lap No. to lap time (Probably we can, but I wasn't able to find an easy way to do this.)
So I now use Race Lap Analysis as the source for lap time data. This PDF explicitly gives the lap No. of cars so no need to determine if a car is lapped. However, no position data is available in this PDF, nor lap 1's lap time data.
So we further use Race Lap Chart PDF to get the car positions, and get lap 1's lap times from Race History Chart