Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get car positions from lap chart PDF (fix #19) #20

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

harningle
Copy link
Owner

This fixed #19

It's very hard to determine the lap of cars from Race History Chart PDF. The PDF ranks cars by their absolute positions. That is, if car A is physically in front of B, A is ranked above B, regardless of whether B is lapped by A or not. When we have both lapped cars and cars in pit, it's hard to tell if a car is lapped, and thus we cannot assign the correct lap No. to lap time (Probably we can, but I wasn't able to find an easy way to do this.)

So I now use Race Lap Analysis as the source for lap time data. This PDF explicitly gives the lap No. of cars so no need to determine if a car is lapped. However, no position data is available in this PDF, nor lap 1's lap time data.

So we further use Race Lap Chart PDF to get the car positions, and get lap 1's lap times from Race History Chart

@harningle
Copy link
Owner Author

this also fixed the parsing error for 2023 vs 2024 quali final classification PDFs: the 2023 one has one more col. so we need to make sure the cols. are aligned properly

@harningle harningle merged commit 117758e into main Dec 19, 2024
2 checks passed
@harningle harningle deleted the fix-car-order branch December 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] position in race lap data is wrong if there are lapped cars
1 participant