Reorganize pdfs, add historic data testing, 2024 entry list support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TODO: still need a bit more cleaning around pit stop and lapping
…testing (harningle#6) * fix `Lap` to use `lap_number` instead of `number`, add ad-hoc smoke tests * add missing type hint * initial pytests, fix linting, add github action * revert `parse_entry_list.py` (did not mean to commit this) * drop camelot from parsing entry list, add tests
* also remove linting test temporarily, for unused imported libs. * the versioning in `requirements.txt` is temporarily removed. Need come back to them later. The previous versioning is too strict I believe. We don't necessarily need that new versions
very preliminary...
* `type` is session type and now we call it `session`. It now takes the values race, Q1, Q2, ... * also explicitly disallow additional fields in all data models
also modify other parsing scripts a bit to accommodate field name changing in 985afd6
* object_type should be lap not fastest_lap
* objects should be a list of dicts, not a dict
* lap_number should be number
|
sorry I mis- force pushed and overwrote the history. I also made big changes to the parsers in the previous days. If you are still interested in working on this, please feel free to open a new PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things, and some are more opinionated. Feel free to criticize or change any aspect.
Let me know what you think. I see that you recently added support for sprint documents, which is awesome to see.