Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Staged Stream Sync Long Range #4824

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

GheisMohammadi
Copy link
Contributor

@GheisMohammadi GheisMohammadi commented Dec 30, 2024

Issue

This PR refactors Staged Stream Sync Long Range stage. It adds BlockHashes stage to Staged Stream Sync. By calculating the correct hash first, this ensures data integrity and reliability in the block download process.

@GheisMohammadi GheisMohammadi self-assigned this Dec 30, 2024
@GheisMohammadi GheisMohammadi marked this pull request as draft December 30, 2024 11:55
@GheisMohammadi GheisMohammadi marked this pull request as ready for review January 6, 2025 11:44
@sophoah
Copy link
Contributor

sophoah commented Jan 9, 2025

is it possible to write test in this PR as well ?

@GheisMohammadi
Copy link
Contributor Author

is it possible to write test in this PR as well ?

done

@sophoah
Copy link
Contributor

sophoah commented Jan 10, 2025

@GheisMohammadi for long range how many block behind are we talking about

@GheisMohammadi
Copy link
Contributor Author

GheisMohammadi commented Jan 10, 2025

@GheisMohammadi for long range how many block behind are we talking about

The node starts in long-range sync mode by default. Once it catches up, it switches to short-range sync.

@GheisMohammadi
Copy link
Contributor Author

@GheisMohammadi for long range how many block behind are we talking about

The node starts in long-range sync mode by default. Once it catches up, it switches to short-range sync.

Also, I am currently working on a PR that dynamically switches between short-range and long-range sync based on the block gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants