Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names in comment #4812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some function names in comment #4812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/configs/sharding/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func (sc instance) SlotsLimit() int {
return sc.slotsLimit
}

// FeeCollector returns a mapping of address to decimal % of fee
// FeeCollectors returns a mapping of address to decimal % of fee
func (sc instance) FeeCollectors() FeeCollectors {
return sc.feeCollectors
}
Expand Down
2 changes: 1 addition & 1 deletion internal/configs/sharding/shardingconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ type Instance interface {
// ExternalAllowlistLimit returns the maximum number of external leader keys on each shard(HIP18)
ExternalAllowlistLimit() int

// FeeCollector returns a mapping of address to decimal % of fee
// FeeCollectors returns a mapping of address to decimal % of fee
FeeCollectors() FeeCollectors

// HIP30RecoveryAddress returns the address to which
Expand Down
4 changes: 2 additions & 2 deletions p2p/stream/protocols/sync/message/compose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func MakeGetBlocksByNumRequest(bns []uint64) *Request {
}
}

// MakeGetBlockByHashesRequest makes the GetBlocksByHashes request
// MakeGetBlocksByHashesRequest makes the GetBlocksByHashes request
func MakeGetBlocksByHashesRequest(hashes []common.Hash) *Request {
return &Request{
Request: &Request_GetBlocksByHashesRequest{
Expand Down Expand Up @@ -182,7 +182,7 @@ func MakeGetBlocksByNumResponseMessage(rid uint64, blocksBytes, sigs [][]byte) *
return makeMessageFromResponse(resp)
}

// MakeGetBlocksByNumResponseMessage make the GetBlocksByNumResponse of Response type
// MakeGetBlocksByNumResponse make the GetBlocksByNumResponse of Response type
func MakeGetBlocksByNumResponse(rid uint64, blocksBytes, sigs [][]byte) *Response {
return &Response{
ReqId: rid,
Expand Down