Restore EMPTY status for multi-threaded tests report

harmin-parra · Oct 8, 2023 · 94de63d · 94de63d
1 parent 5b5be20
commit 94de63d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/src/com/github/report4s/Listeners.java b/src/com/github/report4s/Listeners.java
@@ -517,7 +517,7 @@ private void print_rows() {
                                 suite_md.status);
             }
             if (suite_md.hasMutiThreads)
-                print_method_row(i+1, 0, "<span class=\"multiThread\">No support for multi-threaded tests</span>", null, "", suite_md.filename, Status.UNKNOWN, suite_md.status);
+                print_method_row(i+1, 0, "<span class=\"multiThread\">No support for multi-threaded tests</span>", null, "", suite_md.filename, Status.EMPTY, suite_md.status);
         }
     }
 
@@ -580,8 +580,14 @@ private void print_method_row(
             "                <td></td>" + "\n" +
             "                <td>" + name + "</td>" + "\n" +
             "                <td style=\"text-align:right\">" + time + "</td>" + "\n" +
-            "                <td style=\"text-align:center\"><a target=\"_blank\" href=\"" + file + "\">details</a></td>" + "\n" +
-            "                <td align=\"center\"><img src=\"assets/img/" + icon + "\" class=\"icon\"></td>" + "\n" +
+            "                <td style=\"text-align:center\"><a target=\"_blank\" href=\"" + file + "\">details</a></td>" + "\n");
+        if (status == Status.EMPTY)
+            HtmlWriter.println(
+            "                <td align=\"center\"></td>" + "\n");
+        else
+            HtmlWriter.println(
+            "                <td align=\"center\"><img src=\"assets/img/" + icon + "\" class=\"icon\"></td>" + "\n");
+        HtmlWriter.println(
             "            </tr>");
     }
 

diff --git a/src/com/github/report4s/Status.java b/src/com/github/report4s/Status.java
@@ -10,4 +10,5 @@ enum Status {
     PASSED_WITH_WARNING,
     FAILED_WITHIN_PERCENTAGE,
     UNKNOWN,
+    EMPTY,    //for multi-threaded tests
 }
diff --git a/src/com/github/report4s/Utils.java b/src/com/github/report4s/Utils.java
@@ -436,6 +436,10 @@ protected static String getStatusIconFilename(Status status) {
             case PASSED_WITH_WARNING:
                 icon = "incomplete.png";
                 break;
+            case EMPTY:
+                // For multi-threaded tests
+                icon = "";
+                break;
             default:
                 // Should never happen!
                 icon = "unknown.png";