Fix Ubuntu build (#2797)

* Fix Ubuntu build * bump System.Text.Json * Update Page.workers test
hardkoded · Oct 17, 2024 · 1b2dcca · 1b2dcca
1 parent f5ef2b1
commit 1b2dcca
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -87,6 +87,9 @@ jobs:
     - name: Build
       working-directory: lib
       run: dotnet build PuppeteerSharp.sln
+    - name: Disable AppArmor
+      if: matrix.os == 'ubuntu-latest'
+      run: echo 0 | sudo tee /proc/sys/kernel/apparmor_restrict_unprivileged_userns
     - name: Test (Linux)
       if: matrix.os == 'ubuntu-latest'
       env:

diff --git a/lib/PuppeteerSharp.Tests/WorkerTests/PageWorkerTests.cs b/lib/PuppeteerSharp.Tests/WorkerTests/PageWorkerTests.cs
@@ -25,7 +25,7 @@ await Task.WhenAll(
                 Page.GoToAsync(TestConstants.ServerUrl + "/worker/worker.html"));
             var worker = Page.Workers[0];
             Assert.That(worker.Url, Does.Contain("worker.js"));
-            Assert.That(await worker.EvaluateExpressionAsync<string>("self.workerFunction()"), Is.EqualTo("worker function result"));
+            Assert.That(await worker.EvaluateExpressionAsync<string>("globalThis.workerFunction()"), Is.EqualTo("worker function result"));
 
             await Page.GoToAsync(TestConstants.EmptyPage);
             await workerDestroyedTcs.Task.WithTimeout();

diff --git a/lib/PuppeteerSharp/PuppeteerSharp.csproj b/lib/PuppeteerSharp/PuppeteerSharp.csproj
@@ -46,7 +46,7 @@
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
     <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
-    <PackageReference Include="System.Text.Json" Version="8.0.4" />
+    <PackageReference Include="System.Text.Json" Version="8.0.5" />
   </ItemGroup>
   <ItemGroup>
     <AdditionalFiles Include="..\stylecop.json" Link="stylecop.json" />