homework #135
Open
homework #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spajic
reviewed
Oct 21, 2023
| report['usersStats'][user_key] ||= {} | ||
| report['usersStats'][user_key] = report['usersStats'][user_key].merge(block.call(user)) | ||
| def collect_stats_from_users(report, users, &block) | ||
| progressbar = ProgressBar.create( |
There was a problem hiding this comment.
прогресс-бар кстати может подтормаживать, поэтому при замерах времени (бенчмаркинге) лучше его отключать
There was a problem hiding this comment.
добавил ProgressBar уже после всех оптимизаций, просто для пощупать и галочку проставить
spajic
reviewed
Oct 21, 2023
|
|
||
| report['uniqueBrowsersCount'] = uniqueBrowsers.count | ||
| report[:uniqueBrowsersCount] = sessions.uniq { |session| session[:browser] }.size |
There was a problem hiding this comment.
Уникальные браузеры удобно в Set / SortedSet собирать
spajic
reviewed
Oct 21, 2023
| @@ -72,72 +75,40 @@ def work | |||
|
|
|||
| report = {} | |||
|
|
|||
| report[:totalUsers] = users.count | |||
| report[:totalUsers] = users.size | |||
There was a problem hiding this comment.
для Array size и count - одно и то же
spajic
reviewed
Oct 21, 2023
| def work(filename: nil, disable_gc: false) | ||
| GC.disable if disable_gc | ||
| users = fetch_users_and_sessions(filename) | ||
| sessions = users.flat_map { |user| user[:sessions] } |
There was a problem hiding this comment.
user[:sessions] массив же, без flat_map надо было бы делать flatten после map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Где лучше оставлять вопросы, здесь или в teachbase? Пока оставлю тут:
Как поток понимает, что происходит IO операция, и что будет с потоком, когда IO операция завершится? За это ядро ОС отвечает? Где можно подробности работы с потоками и процессами разобрать?
Отчет в https://www.speedscope.app не открылся, ругается на формат, хотя кидаю сгенерированный json