BUG/MEDIUM: quic: properly decount out-of-order ACK on stream release #3016
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Copyright 2019 Ilya Shipitsin <[email protected]> | |
| # Copyright 2020 Tim Duesterhus <[email protected]> | |
| # | |
| # This program is free software; you can redistribute it and/or | |
| # modify it under the terms of the GNU General Public License | |
| # as published by the Free Software Foundation; either version | |
| # 2 of the License, or (at your option) any later version. | |
| name: VTest | |
| on: | |
| push: | |
| permissions: | |
| contents: read | |
| jobs: | |
| # The generate-matrix job generates the build matrix using JSON output | |
| # generated by .github/matrix.py. | |
| generate-matrix: | |
| name: Generate Build Matrix | |
| runs-on: ubuntu-latest | |
| outputs: | |
| matrix: ${{ steps.set-matrix.outputs.matrix }} | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - name: Generate Build Matrix | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| id: set-matrix | |
| run: python3 .github/matrix.py "${{ github.ref_name }}" | |
| # The Test job actually runs the tests. | |
| Test: | |
| name: ${{ matrix.name }} | |
| needs: generate-matrix | |
| runs-on: ${{ matrix.os }} | |
| strategy: | |
| matrix: ${{ fromJson(needs.generate-matrix.outputs.matrix) }} | |
| fail-fast: false | |
| env: | |
| # Configure a short TMPDIR to prevent failures due to long unix socket | |
| # paths. | |
| TMPDIR: /tmp | |
| OT_CPP_VERSION: 1.6.0 | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 100 | |
| - name: Setup coredumps | |
| if: ${{ startsWith(matrix.os, 'ubuntu-') }} | |
| run: | | |
| sudo sysctl -w fs.suid_dumpable=1 | |
| sudo sysctl kernel.core_pattern=/tmp/core.%h.%e.%t | |
| # | |
| # Github Action cache key cannot contain comma, so we calculate it based on job name | |
| # | |
| - name: Generate cache key | |
| id: generate-cache-key | |
| run: | | |
| echo "key=$(echo ${{ matrix.name }} | sha256sum | awk '{print $1}')" >> $GITHUB_OUTPUT | |
| - name: Cache SSL libs | |
| if: ${{ matrix.ssl && matrix.ssl != 'stock' && matrix.ssl != 'BORINGSSL=yes' && matrix.ssl != 'QUICTLS=yes' }} | |
| id: cache_ssl | |
| uses: actions/cache@v4 | |
| with: | |
| path: '~/opt/' | |
| key: ssl-${{ steps.generate-cache-key.outputs.key }} | |
| - name: Cache OpenTracing | |
| if: ${{ contains(matrix.FLAGS, 'USE_OT=1') }} | |
| id: cache_ot | |
| uses: actions/cache@v4 | |
| with: | |
| path: '~/opt-ot/' | |
| key: ot-${{ matrix.CC }}-${{ env.OT_CPP_VERSION }}-${{ contains(matrix.name, 'ASAN') }} | |
| - name: Install apt dependencies | |
| if: ${{ startsWith(matrix.os, 'ubuntu-') }} | |
| run: | | |
| sudo apt-get update -o Acquire::Languages=none -o Acquire::Translation=none | |
| sudo apt-get --no-install-recommends -y install \ | |
| ${{ contains(matrix.FLAGS, 'USE_LUA=1') && 'liblua5.4-dev' || '' }} \ | |
| ${{ contains(matrix.FLAGS, 'USE_PCRE2=1') && 'libpcre2-dev' || '' }} \ | |
| ${{ contains(matrix.ssl, 'BORINGSSL=yes') && 'ninja-build' || '' }} \ | |
| socat \ | |
| gdb | |
| - name: Install brew dependencies | |
| if: ${{ startsWith(matrix.os, 'macos-') }} | |
| run: | | |
| brew install socat | |
| brew install lua | |
| - name: Install VTest | |
| run: | | |
| scripts/build-vtest.sh | |
| - name: Install SSL ${{ matrix.ssl }} | |
| if: ${{ matrix.ssl && matrix.ssl != 'stock' && steps.cache_ssl.outputs.cache-hit != 'true' }} | |
| run: env ${{ matrix.ssl }} scripts/build-ssl.sh | |
| - name: Install OpenTracing libs | |
| if: ${{ contains(matrix.FLAGS, 'USE_OT=1') && steps.cache_ot.outputs.cache-hit != 'true' }} | |
| run: | | |
| OT_PREFIX=${HOME}/opt-ot scripts/build-ot.sh | |
| - name: Build WURFL | |
| if: ${{ contains(matrix.FLAGS, 'USE_WURFL=1') }} | |
| run: make -C addons/wurfl/dummy | |
| - name: Compile HAProxy with ${{ matrix.CC }} | |
| run: | | |
| echo "::group::Show compiler's version" | |
| echo | ${{ matrix.CC }} -v | |
| echo "::endgroup::" | |
| echo "::group::Show platform specific defines" | |
| echo | ${{ matrix.CC }} -dM -xc -E - | |
| echo "::endgroup::" | |
| make -j$(nproc) all \ | |
| ERR=1 \ | |
| TARGET=${{ matrix.TARGET }} \ | |
| CC=${{ matrix.CC }} \ | |
| DEBUG="-DDEBUG_POOL_INTEGRITY" \ | |
| ${{ join(matrix.FLAGS, ' ') }} \ | |
| ADDLIB="-Wl,-rpath,/usr/local/lib/ -Wl,-rpath,$HOME/opt/lib/" | |
| sudo make install | |
| - name: Show HAProxy version | |
| id: show-version | |
| run: | | |
| echo "::group::Show dynamic libraries." | |
| if command -v ldd > /dev/null; then | |
| # Linux | |
| ldd $(which haproxy) | |
| else | |
| # macOS | |
| otool -L $(which haproxy) | |
| fi | |
| echo "::endgroup::" | |
| haproxy -vv | |
| echo "version=$(haproxy -v |awk 'NR==1{print $3}')" >> $GITHUB_OUTPUT | |
| - name: Install problem matcher for VTest | |
| # This allows one to more easily see which tests fail. | |
| run: echo "::add-matcher::.github/vtest.json" | |
| - name: Run VTest for HAProxy ${{ steps.show-version.outputs.version }} | |
| id: vtest | |
| run: | | |
| # This is required for macOS which does not actually allow to increase | |
| # the '-n' soft limit to the hard limit, thus failing to run. | |
| ulimit -n 65536 | |
| ulimit -c unlimited | |
| make reg-tests VTEST_PROGRAM=../vtest/vtest REGTESTS_TYPES=default,bug,devel | |
| - name: Config syntax check memleak smoke testing | |
| if: ${{ contains(matrix.name, 'ASAN') }} | |
| run: | | |
| ./haproxy -dI -f .github/h2spec.config -c | |
| ./haproxy -dI -f examples/content-sw-sample.cfg -c | |
| ./haproxy -dI -f examples/option-http_proxy.cfg -c | |
| ./haproxy -dI -f examples/quick-test.cfg -c | |
| ./haproxy -dI -f examples/transparent_proxy.cfg -c | |
| - name: Show VTest results | |
| if: ${{ failure() && steps.vtest.outcome == 'failure' }} | |
| run: | | |
| for folder in ${TMPDIR}/haregtests-*/vtc.*; do | |
| printf "::group::" | |
| cat $folder/INFO | |
| cat $folder/LOG | |
| echo "::endgroup::" | |
| done | |
| exit 1 | |
| - name: Show coredumps | |
| if: ${{ failure() && steps.vtest.outcome == 'failure' }} | |
| run: | | |
| failed=false | |
| shopt -s nullglob | |
| for file in /tmp/core.*; do | |
| failed=true | |
| printf "::group::" | |
| gdb -ex 'thread apply all bt full' ./haproxy $file | |
| echo "::endgroup::" | |
| done | |
| if [ "$failed" = true ]; then | |
| exit 1; | |
| fi |