Merge pull request #75 from happyprime/repo-sync/projects/default

Update: synced file(s) with happyprime/projects
happyprime · Nov 16, 2023 · 9c5fc32 · 9c5fc32
2 parents b6e4471 + 24019d6
commit 9c5fc32
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 21 deletions.
diff --git a/.github/workflows/issues.yml b/.github/workflows/issues.yml
@@ -1,3 +1,4 @@
+# This file is managed in https://github.com/happyprime/projects
 name: Add new issues to Happy Prime project
 
 on:

diff --git a/.github/workflows/phpcs.yml b/.github/workflows/phpcs.yml
@@ -1,4 +1,5 @@
-name: PHPCS (Default)
+# This file is managed in https://github.com/happyprime/projects
+name: PHPCS (Default, PHP 8.2)
 
 on: pull_request
 

diff --git a/.github/workflows/verify-build.yml b/.github/workflows/verify-build.yml
@@ -1,7 +1,16 @@
-name: Node.js CI
+# This file is managed in https://github.com/happyprime/projects
+name: Verify build (Node 18)
 
 on: [ pull_request ]
 
+# The GITHUB_TOKEN used by Dependabot has read-only permissions
+# by default, so we provide write permissions to this workflow
+# so that comments can be left on the pull request.
+# https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#changing-github_token-permissions
+permissions:
+  contents: read
+  pull-requests: write
+
 jobs:
   build:
     name: Check built files
@@ -13,31 +22,43 @@ jobs:
       uses: actions/checkout@v4
       with:
         fetch-depth: 2
-    - name: Setup Node.js LTS
+
+    - name: Setup Node
       uses: actions/setup-node@v4
       with:
-        node-version: 'lts/*'
-    - name: Install latest NPM
-      run: npm install -g npm
-    - name: Install project dependencies
-      run: npm ci
-    - name: Run build process(es)
-      run: |
-        npm run build
-    - name: Check Git status
+        node-version: 18
+        cache: 'npm'
+
+    - name: Verify Node dependency cache
+      uses: actions/cache@v3
+      with:
+        path: ./node_modules
+        key: node-dependencies-${{ hashFiles('package-lock.json') }}
+        restore-keys: node-dependencies-
+
+    - name: Install Node dependencies
+      run: npm install
+
+    - name: Build
+      run: npm run build
+
+    - name: Capture Git status
       id: git
       shell: bash
       run: |
-        RESULT=$(git status)
-        RESULT="${RESULT//'%'/'%25'}"
-        RESULT="${RESULT//$'\n'/'%0A'}"
-        RESULT="${RESULT//$'\r'/'%0D'}"
-        echo "::set-output name=changes::$RESULT"
-        echo "::set-output name=nodeVersion::$(node --version)"
-        echo "::set-output name=npmVersion::$(npm --version)"
-        if [[ $RESULT == *"Changes not staged"* || $RESULT == *"Untracked files"* ]]; then
+        echo 'changes<<EOF' >> $GITHUB_OUTPUT
+        echo "$(git status --porcelain --untracked-files=all)" >> $GITHUB_OUTPUT
+        echo 'EOF' >> $GITHUB_OUTPUT
+        echo "nodeVersion=$(node --version)" >> $GITHUB_OUTPUT
+        echo "npmVersion=$(npm --version)" >> $GITHUB_OUTPUT
+
+    - name: Fail if changes detected
+      shell: bash
+      run: |
+        if [[ -n "${{ steps.git.outputs.changes }}" ]]; then
           exit 1
         fi
+
     - name: Comment on pull request
       if: failure()
       uses: actions/github-script@v7
@@ -54,7 +75,7 @@ jobs:
           * NPM ${{ steps.git.outputs.npmVersion }}
           `;
 
-          github.issues.createComment({
+          github.rest.issues.createComment({
             ...context.repo,
             issue_number: context.payload.pull_request.number,
             body: output