Skip to content

Commit

Permalink
ci: adjust finish-coverage-report job condition for strict workflow c…
Browse files Browse the repository at this point in the history
…ontrol

Signed-off-by: Marko Kungla <[email protected]>
  • Loading branch information
mkungla committed Jan 29, 2024
1 parent a38fc39 commit b48b1a6
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/monorepo-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ on:
workflow_dispatch:
inputs:
strict:
description: 'Set to false to allow workflow to continue on errors'
description: 'Set to true to make the workflow fail on the first error'
required: false
default: 'true'
default: 'false'

jobs:
lint:
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
matrix:
module: ${{ fromJson(needs.list-modules.outputs.modules) }}
platform: [ubuntu-latest, macos-latest, windows-latest]
fail-fast: ${{ github.event.inputs.strict == 'true' || github.event_name != 'workflow_dispatch' }}
fail-fast: ${{ github.event.inputs.strict == 'true' }}
runs-on: ${{ matrix.platform }}
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -94,12 +94,12 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
file: ${{ matrix.module }}/coverage.out

finish-coverage-report:
needs: coverage
if: always() && (github.event.inputs.strict == 'false' || success())
runs-on: ubuntu-latest
steps:
- name: Coveralls Finish
uses: coverallsapp/github-action@v2
with:
parallel-finished: true
finish-coverage-report:
needs: coverage
if: github.event.inputs.strict == 'false' || success()
runs-on: ubuntu-latest
steps:
- name: Coveralls Finish
uses: coverallsapp/github-action@v2
with:
parallel-finished: true

0 comments on commit b48b1a6

Please sign in to comment.