ci: fix action comp

Signed-off-by: Marko Kungla <[email protected]>
happy-sdk · Jan 29, 2024 · 9f5bf7e · 9f5bf7e
1 parent 67eced7
commit 9f5bf7e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.github/actions/go-test-monorepo-action/go-test-monorepo-action.ps1 b/.github/actions/go-test-monorepo-action/go-test-monorepo-action.ps1
@@ -11,10 +11,10 @@ Get-ChildItem -File -Recurse -Filter "go.mod" | ForEach-Object {
   $modules += $module
 
   # Run tests only if ONLY_MODULE_LIST is not "true"
-  if ($ONLY_MODULE_LIST -ne "true") {
+  if ($ONLY_MODULE_LIST != "true") {
     Write-Host "Testing and generating coverage for module: $module"
     Set-Location $module
-    if ($GO_TEST_RACE -eq "true") {
+    if ($GO_TEST_RACE == "true") {
       go test -race -coverpkg=./... -coverprofile=coverage.out -timeout=1m ./...
     } else {
       go test -coverpkg=./... -coverprofile=coverage.out -timeout=1m ./...

diff --git a/.github/actions/go-test-monorepo-action/go-test-monorepo-action.sh b/.github/actions/go-test-monorepo-action/go-test-monorepo-action.sh
@@ -12,9 +12,9 @@ while IFS= read -r module; do
   modules+=("$module")
 
   # Run tests only if ONLY_MODULE_LIST is not "true"
-  if [ "$ONLY_MODULE_LIST" -ne "true" ]; then
+  if [ "$ONLY_MODULE_LIST" != "true" ]; then
     echo "Testing and generating coverage for module: $module"
-    if [ "$GO_TEST_RACE" -eq "true" ]; then
+    if [ "$GO_TEST_RACE" == "true" ]; then
       (cd "$module" && go test -race -coverpkg=./... -coverprofile=coverage.out -timeout=1m ./...)
     else
        (cd "$module" && go test -coverpkg=./... -coverprofile=coverage.out -timeout=1m ./...)

diff --git a/.github/workflows/monorepo-main.yml b/.github/workflows/monorepo-main.yml
@@ -45,7 +45,7 @@ jobs:
           go-version: '>=1.21.0'
           only-module-list: true
 
-  coverage:
+  test-n-coverage:
     needs: list-modules
     strategy:
       matrix:
@@ -63,7 +63,7 @@ jobs:
           race: ${{ github.event.inputs.loose != 'true' }}
 
       - name: Check if coverage data exists
-        if: success() || failure()
+        if: github.event.inputs.loose == 'true' || success()
         id: check-coverage
         working-directory: ${{ matrix.module }}
         run: |
@@ -96,7 +96,7 @@ jobs:
           file: ${{ matrix.module }}/coverage.out
 
   finish-coverage-report:
-    needs: coverage
+    needs: test-n-coverage
     if: github.event.inputs.loose == 'true' || success()
     runs-on: ubuntu-latest
     steps: