Skip to content

Commit

Permalink
fix: add benchmarks
Browse files Browse the repository at this point in the history 
Signed-off-by: Marko Kungla <[email protected]>
  • Loading branch information
@mkungla
mkungla committed Jan 31, 2024
1 parent 02f67db commit 3c24c26
Show file tree
Hide file tree
Showing 4 changed files with 187 additions and 181 deletions.
48 changes: 0 additions & 48 deletions pkg/strings/bexp/benchmark_priv_test.go
View file

This file was deleted.

316 changes: 183 additions & 133 deletions pkg/strings/bexp/benchmark_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,142 +2,192 @@
//
// Copyright © 2020 The Happy Authors

package bexp_test
package bexp

// import (
// "fmt"
// "os/exec"
// "strings"
// "testing"
import (
"fmt"
"os/exec"
"regexp"
"strings"
"testing"

// "github.com/happy-sdk/bexp"
// "github.com/stretchr/testify/assert"
// )
"github.com/happy-sdk/happy/pkg/devel/testutils"
)

// type benchTest struct {
// Pattern string
// Res0 string
// Res1 string
// Res2 string
// }
type benchTest struct {
Pattern string
Res0 string
Res1 string
Res2 string
}

// type benchTestGroup struct {
// Name string
// Tests []benchTest
// }
type benchTestGroup struct {
Name string
Tests []benchTest
}

// //nolint: gochecknoglobals
// var benchdata = []benchTestGroup{
// {
// "fs-path",
// []benchTest{
// {
// "data/{P1/{10..19},P2/{20..29},P3/{30..39}}",
// "data/P1/10", "data/P1/11", "data/P1/12",
// },
// {
// "/usr/{ucb/{ex,edit},lib/{ex?.?*,how_ex}}",
// "/usr/ucb/ex", "/usr/ucb/edit", "/usr/lib/ex?.?*",
// },
// {
// "/usr/local/src/bash/{old,new,dist,bugs}",
// "/usr/local/src/bash/old",
// "/usr/local/src/bash/new",
// "/usr/local/src/bash/dist",
// },
// },
// },
// {
// "string",
// []benchTest{
// {"{a,b}x{1,2}", "ax1", "ax2", "bx1"},
// {"{a,{{{b}}}}", "a", "{{{b}}}", ""},
// {"{a{1,2}b}", "{a1b}", "{a2b}", ""},
// {"a{b,c,}", "ab", "ac", "a"},
// {"{,,,}", "", "", ""},
// {"{}", "{}", "", ""},
// {"a,,b", "a,,b", "", ""},
// {",a", ",a", "", ""},
// },
// },
// {
// "url",
// []benchTest{
// {
// "https://tile.openstreetmap.org/1/{10..30}/{10..30}.png",
// "https://tile.openstreetmap.org/1/10/10.png",
// "https://tile.openstreetmap.org/1/10/11.png",
// "https://tile.openstreetmap.org/1/10/12.png",
// },
// {
// "https://example.cdn/{image-series-{a,b}-{1,2}.png",
// "https://example.cdn/{image-series-a-1.png",
// "https://example.cdn/{image-series-a-2.png",
// "https://example.cdn/{image-series-b-1.png",
// },
// },
// },
// {
// "number",
// []benchTest{
// {
// "{1..3}",
// "1",
// "2",
// "3",
// },
// {
// "{3..1}",
// "3",
// "2",
// "1",
// },
// },
// },
// }
// nolint: gochecknoglobals
var benchdata = []benchTestGroup{
{
"fs-path",
[]benchTest{
{
"data/{P1/{10..19},P2/{20..29},P3/{30..39}}",
"data/P1/10", "data/P1/11", "data/P1/12",
},
{
"/usr/{ucb/{ex,edit},lib/{ex?.?*,how_ex}}",
"/usr/ucb/ex", "/usr/ucb/edit", "/usr/lib/ex?.?*",
},
{
"/usr/local/src/bash/{old,new,dist,bugs}",
"/usr/local/src/bash/old",
"/usr/local/src/bash/new",
"/usr/local/src/bash/dist",
},
},
},
{
"string",
[]benchTest{
{"{a,b}x{1,2}", "ax1", "ax2", "bx1"},
{"{a,{{{b}}}}", "a", "{{{b}}}", ""},
{"{a{1,2}b}", "{a1b}", "{a2b}", ""},
{"a{b,c,}", "ab", "ac", "a"},
{"{,,,}", "", "", ""},
{"{}", "{}", "", ""},
{"a,,b", "a,,b", "", ""},
{",a", ",a", "", ""},
},
},
{
"url",
[]benchTest{
{
"https://tile.openstreetmap.org/1/{10..30}/{10..30}.png",
"https://tile.openstreetmap.org/1/10/10.png",
"https://tile.openstreetmap.org/1/10/11.png",
"https://tile.openstreetmap.org/1/10/12.png",
},
{
"https://example.cdn/{image-series-{a,b}-{1,2}.png",
"https://example.cdn/{image-series-a-1.png",
"https://example.cdn/{image-series-a-2.png",
"https://example.cdn/{image-series-b-1.png",
},
},
},
{
"number",
[]benchTest{
{
"{1..3}",
"1",
"2",
"3",
},
{
"{3..1}",
"3",
"2",
"1",
},
},
},
}

// // TestBenchData tests bench data so that we dont need to validate results when benchmarking.
// func TestBenchData(t *testing.T) {
// checkbash := true
// if _, err := exec.LookPath("bash"); err != nil {
// checkbash = false
// }
// for _, group := range benchdata {
// t.Run(group.Name, func(t *testing.T) {
// t.Parallel()
// for _, test := range group.Tests {
// v, _ := bexp.ParseValid(test.Pattern)
// if len(v) > 0 {
// assert.Equal(t, test.Res0, v[0])
// }
// if len(v) > 1 {
// assert.Equal(t, test.Res1, v[1])
// }
// if len(v) > 2 {
// assert.Equal(t, test.Res2, v[2])
// }
// if checkbash {
// out, err := exec.Command("bash", "-c", fmt.Sprintf("echo %s", test.Pattern)).Output()
// assert.NoError(t, err)
// res := strings.Fields(string(out))
// assert.False(t, len(test.Res0) > 0 && len(res) == 0, "bash -c returned empty result expecting: ", test.Res0)
// assert.False(t, len(test.Res1) > 0 && len(res) < 2, "bash -c less than 2 matches")
// assert.False(t, len(test.Res2) > 0 && len(res) < 3, "bash -c less than 3 matches")
// }
// }
// })
// }
// }
// func BenchmarkParseValid(b *testing.B) {
// for _, group := range benchdata {
// b.Run(group.Name, func(b *testing.B) {
// for _, test := range group.Tests {
// b.Run(test.Pattern, func(b *testing.B) {
// for i := 0; i < b.N; i++ {
// bexp.ParseValid(test.Pattern)
// }
// })
// }
// })
// }
// }
func BenchmarkParse(b *testing.B) {
for _, group := range benchdata {
b.Run(group.Name, func(b *testing.B) {
for i := 0; i < b.N; i++ {
for _, test := range group.Tests {
_ = Parse(test.Pattern)
}
}
})
}
}

// TestBenchData tests bench data so that we dont need to validate results when benchmarking.
func TestBenchData(t *testing.T) {
checkbash := true
if _, err := exec.LookPath("bash"); err != nil {
checkbash = false
}
for _, group := range benchdata {
g := group
t.Run(g.Name, func(t *testing.T) {
t.Parallel()
for _, test := range g.Tests {
v, _ := ParseValid(test.Pattern)
if len(v) > 0 {
testutils.Equal(t, test.Res0, v[0])
}
if len(v) > 1 {
testutils.Equal(t, test.Res1, v[1])
}
if len(v) > 2 {
testutils.Equal(t, test.Res2, v[2])
}
if checkbash {
out, err := exec.Command("bash", "-c", fmt.Sprintf("echo %s", test.Pattern)).Output()
testutils.NoError(t, err)
res := strings.Fields(string(out))
testutils.False(t, len(test.Res0) > 0 && len(res) == 0, "bash -c returned empty result expecting: ", test.Res0)
testutils.False(t, len(test.Res1) > 0 && len(res) < 2, "bash -c less than 2 matches")
testutils.False(t, len(test.Res2) > 0 && len(res) < 3, "bash -c less than 3 matches")
}
}
})
}
}

func BenchmarkParseValid(b *testing.B) {
for _, group := range benchdata {
b.Run(group.Name, func(b *testing.B) {
for i := 0; i < b.N; i++ {
for _, test := range group.Tests {
ParseValid(test.Pattern)
}
}
})
}
}

func BenchmarkIsPadded(b *testing.B) {
tests := []struct {
in string
want bool
}{
{"01", true},
{"00001", true},
{"-01", true},
{"-00001", true},
{"-00", true},
{"00", true},
{"00string", true},
{"-00string", true},
}
b.Run("isPadded", func(b *testing.B) {
for i := 0; i < b.N; i++ {
for _, test := range tests {
res := isPadded(test.in)
if res != test.want {
b.Errorf("expected %t got %t", !test.want, test.want)
}
}
}
})

re := regexp.MustCompile(`^-?0\d`)
b.Run("GO/isPaddedRegexp", func(b *testing.B) {
for i := 0; i < b.N; i++ {
for _, test := range tests {
res := re.MatchString(test.in)
if res != test.want {
b.Errorf("expected %t got %t", !test.want, test.want)
}
}
}
})
}
2 changes: 2 additions & 0 deletions pkg/strings/bexp/go.mod
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
module github.com/happy-sdk/happy/pkg/strings/bexp

go 1.21.5

require github.com/happy-sdk/happy/pkg/devel/testutils v0.5.0
2 changes: 2 additions & 0 deletions pkg/strings/bexp/go.sum
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
github.com/happy-sdk/happy/pkg/devel/testutils v0.5.0 h1:VMEbLL4CmBSn/w1yUO1jDq1RnnNA5IMcuaH41mpf/sk=
github.com/happy-sdk/happy/pkg/devel/testutils v0.5.0/go.mod h1:RhJucLCtEYMceBiIex9+9YmR05q0zs9qchSLnUDdFeY=

0 comments on commit 3c24c26

Please sign in to comment.