Skip to content

Commit

Permalink
Use ExternalProject_Add to install iphreeqc (#3)
Browse files Browse the repository at this point in the history
* Build IPhreeqc seperatly

* Remove apply_patch

* Remove circle ci

* add sudo

* Use ExternalProject_Add

* Add pic

* Add option IPHREEQC_VERSION

* add publish to test pypi ci
  • Loading branch information
haohanyang authored Nov 21, 2024
1 parent f57b0dd commit 0d3ca7d
Show file tree
Hide file tree
Showing 11 changed files with 144 additions and 554 deletions.
81 changes: 0 additions & 81 deletions .circleci/config.yml

This file was deleted.

12 changes: 8 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,21 @@ on:
- README.md

jobs:
build-and-test:
name: Build and test
runs-on: ubuntu-latest
build-iphreeqc:
name: Build IPhreeqc Python bindings
strategy:
fail-fast: true
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
with:
submodules: true
- uses: actions/setup-python@v5
with:
python-version: '3.12'
- name: Build the package using pip
- name: Build Python bindings
run: pip install . pytest
- name: Test
run: pytest tests
85 changes: 85 additions & 0 deletions .github/workflows/test-pypi.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
name: Build wheels and publish to test pypi

on:
workflow_dispatch:
inputs:
package_version:
description: "Version of phreeqc package"
type: string
required: true

jobs:
build-sdist:
name: Build sdist
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true
- uses: actions/setup-python@v5
with:
python-version: '3.9'
- name: Update version
run: python script.py version ${{ github.event.inputs.package_version }}
- name: Build sdist
run: pipx run build --sdist
- name: Check metadata
run: pipx run twine check dist/*
- uses: actions/upload-artifact@v4
with:
name: cibw-sdist
path: dist/*.tar.gz

build-wheels:
name: Build wheels
runs-on: ${{ matrix.os }}
strategy:
fail-fast: true
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
steps:
- uses: actions/checkout@v4
with:
submodules: true
- uses: actions/setup-python@v5
with:
python-version: '3.9'
- name: Update version
run: python script.py version ${{ github.event.inputs.package_version }}
- name: Build wheels
uses: pypa/[email protected]
env:
CIBW_ARCHS_MACOS: "x86_64 arm64"
CIBW_ARCHS_WINDOWS: AMD64
CIBW_ARCHS_LINUX: x86_64
- name: Upload wheels
uses: actions/upload-artifact@v4
with:
name: cibw-wheels-${{ matrix.os }}
path: wheelhouse/*.whl

publish:
name: Publish wheels to pypi
runs-on: ubuntu-latest
needs: [build-wheels, build-sdist]
permissions:
id-token: write
attestations: write
steps:
- name: Download all dists
uses: actions/download-artifact@v4
with:
path: dist
pattern: cibw-*
merge-multiple: true
- name: Generate artifact attestation for sdist and wheels
uses: actions/attest-build-provenance@v1
with:
subject-path: "dist/*"
- name: Publish package to test pypi
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
verbose: true
attestations: true
repository-url: https://test.pypi.org/legacy/
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -188,4 +188,7 @@ dmypy.json
.pytype/

# Cython debug symbols
cython_debug/
cython_debug/

iphreeqc-build/
iphreeqc-install/
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[submodule "pybind11"]
path = pybind11
url = https://github.com/pybind/pybind11.git
[submodule "iphreeqc"]
path = iphreeqc
url = https://github.com/usgs-coupled/iphreeqc.git
Loading

0 comments on commit 0d3ca7d

Please sign in to comment.