Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: reorder storage #3416

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

rueblimaster
Copy link
Contributor

@rueblimaster rueblimaster commented Feb 10, 2025

What

reordered ProfileSpecificStorage,kt and added comments to specify which feature goes where
also rearranged PlayerSpecificStorage.kt
as I found it somewhat of a mess

Changelog Technical Details

  • Reordered internal storage. - rueblimaster

@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Feb 10, 2025
@rueblimaster
Copy link
Contributor Author

I'm right with no changelog right?

@Thunderblade73
Copy link
Contributor

I'm right with no changelog right?

This should get a entry in Technical.
exclude_from_changelog idealy shouldn't be used.

@rueblimaster
Copy link
Contributor Author

also, we could go the route of each feature etc gets its own class, but that would need a lot more work as we'd have to fix all the config links etc

@rueblimaster
Copy link
Contributor Author

I'm right with no changelog right?

This should get a entry in Technical. exclude_from_changelog idealy shouldn't be used.

ok, ty, I guess like this?

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall.
in the end we want to use classes isntead of comments, though this can happen later

@rueblimaster
Copy link
Contributor Author

looks good overall. in the end we want to use classes instead of comments, though this can happen later

yes classes are the way to go. The switch itself will just be quite some work as we'd have to fix all the config links

@hannibal002 hannibal002 merged commit 89b99e1 into hannibal002:beta Feb 11, 2025
6 checks passed
@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Feb 11, 2025
@rueblimaster rueblimaster deleted the reordered-storage branch February 11, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants