-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: reorder storage #3416
Backend: reorder storage #3416
Conversation
I'm right with no changelog right? |
This should get a entry in Technical. |
also, we could go the route of each feature etc gets its own class, but that would need a lot more work as we'd have to fix all the config links etc |
ok, ty, I guess like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall.
in the end we want to use classes isntead of comments, though this can happen later
src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.kt
Outdated
Show resolved
Hide resolved
yes classes are the way to go. The switch itself will just be quite some work as we'd have to fix all the config links |
What
reordered ProfileSpecificStorage,kt and added comments to specify which feature goes where
also rearranged PlayerSpecificStorage.kt
as I found it somewhat of a mess
Changelog Technical Details