-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Scrolling List #3375
Fix: Scrolling List #3375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can still reproduce the bug in the Chest Value display. In other displays it was not a problem prior.
I assume this happens because the chest value display gets recreated very frequently
They cake tracker is the only one that uses the showScrollableTipsInList flag as far as I know. And this manly fixed that one. But also fixed a wrong Conduite to a break, which just gives a bit more performance. |
Well, reading is hard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look at that tomorrow. |
I was trying to work on a better version of this, but Renderable was kicking my ass, and I pretty much gave up on making progress. /CakeTrackerFix |
What
Fixed weird behavior of the scrolling list that where introduced a while ago.
Extra:
I fixed the Renderable.scrollableList for the use case in #3362 and those fixed apply to any use of the scrollableList that use the showScrollableTipsInList flag which is currently only the one in the Cake tracker.
Changelog Fixes