Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Scrolling List #3375

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Conversation

Thunderblade73
Copy link
Contributor

@Thunderblade73 Thunderblade73 commented Feb 6, 2025

What

Fixed weird behavior of the scrolling list that where introduced a while ago.

Extra:
I fixed the Renderable.scrollableList for the use case in #3362 and those fixed apply to any use of the scrollableList that use the showScrollableTipsInList flag which is currently only the one in the Cake tracker.

Changelog Fixes

  • Fixed inconsistent scrolling in some SH GUIs. - Thunderblade73

@github-actions github-actions bot added the Bug Fix Bug fixes label Feb 6, 2025
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the bug in the Chest Value display. In other displays it was not a problem prior.
I assume this happens because the chest value display gets recreated very frequently

@Thunderblade73
Copy link
Contributor Author

I can still reproduce the bug in the Chest Value display. In other displays it was not a problem prior. I assume this happens because the chest value display gets recreated very frequently

They cake tracker is the only one that uses the showScrollableTipsInList flag as far as I know. And this manly fixed that one. But also fixed a wrong Conduite to a break, which just gives a bit more performance.

@hannibal002
Copy link
Owner

Well, reading is hard.
Scrollable list is not the same as scroll in inventory buttons.

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tip consistency breaks after scrolling, and after scrolling down ince the bottom is also wrong
grafik

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the list is too long
grafik
even though the gui is smaller
grafik

also there is still a offset
grafik

@hannibal002
Copy link
Owner

maybe those images help

very bottom
grafik

one scroll above the very bottom
grafik

@Thunderblade73
Copy link
Contributor Author

Will look at that tomorrow.

@DavidArthurCole
Copy link
Contributor

image

I was trying to work on a better version of this, but Renderable was kicking my ass, and I pretty much gave up on making progress. /CakeTrackerFix

@hannibal002 hannibal002 added this to the 2.0.0 milestone Feb 6, 2025
@hannibal002 hannibal002 merged commit dcf3e57 into hannibal002:beta Feb 9, 2025
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants