Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Config to Kotlin #9 #3334

Open
wants to merge 10 commits into
base: beta
Choose a base branch
from
Open

Backend: Config to Kotlin #9 #3334

wants to merge 10 commits into from

Conversation

DavidArthurCole
Copy link
Contributor

What

Ports all configs from config/features/dev package, and About.java to Kotlin.
Also edited the ConfigNeedsExpose rule to ignore @Transient annotated values.

exclude_from_changelog

@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Jan 29, 2025
@hannibal002 hannibal002 added this to the 3.0.0 milestone Jan 29, 2025
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 29, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 29, 2025
@github-actions github-actions bot added the Detekt Has detekt problem label Jan 29, 2025
@github-actions GitHub Actions
Copy link

One or more Detekt Failures were detected:

  • RepositoryConfig.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
  • RepositoryConfig.kt#L3: Unnecessary semicolon

@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 29, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Feb 6, 2025
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Feb 10, 2025
@github-actions github-actions bot added the Detekt Has detekt problem label Feb 10, 2025
@github-actions GitHub Actions
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidArthurCole @hannibal002