Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: More accurate burrow prediction #3249

Open
wants to merge 34 commits into
base: beta
Choose a base branch
from

Conversation

Bloxigus
Copy link

@Bloxigus Bloxigus commented Jan 19, 2025

What

This PR adds a more accurate Diana burrow guesser.

This guesser converts the received particles into 3 2 dimensional polynomials with respect to an unknown variable t, then uses known information about the control points used to generate the locations to determine the exact position of the burrow.

Also adds two small utility classes which help fit a degree 3 polynomial to the known positions of the particles.

I tested on Hypixel during a Diana event and was unable to discover scenarios where this guesser was inaccurate

Changelog New Features

  • More accurate burrow prediction. - bloxigus

@NopoTheGamer
Copy link
Contributor

if you want to ask for help go to #coding on the skyhanni discord

@Bloxigus Bloxigus marked this pull request as ready for review January 19, 2025 13:49
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Jan 19, 2025
Copy link

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + More accurate burrow guessing - your_name_here
Change should end with a full stop in text: More accurate burrow guessing

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@Bloxigus Bloxigus changed the title More accurate burrow prediction Feature: More accurate burrow prediction Jan 19, 2025
@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Jan 19, 2025
@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 19, 2025
@github-actions github-actions bot added the Detekt Has detekt problem label Jan 19, 2025
Copy link

One or more Detekt Failures were detected:

Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot added Merge Conflicts There are open merge conflicts with the beta branch. and removed Detekt Has detekt problem labels Jan 20, 2025
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/event/diana/SoopyGuessBurrow.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 22, 2025
Copy link

Conflicts have been resolved! 🎉

Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 26, 2025
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Detekt Has detekt problem label Jan 26, 2025
Copy link

One or more Detekt Failures were detected:

  • GriffinBurrowHelper.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.

@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 26, 2025
@hannibal002 hannibal002 modified the milestones: 2.0.0, 3.0.0 Jan 29, 2025
Prevent reusing Diana Spade while on cooldown incorrectly invalidating previous data
Updated ConfigFix
Copy link
Contributor

@ItsEmpa ItsEmpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

havent tested ingame yet, just looked at the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants