-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: More accurate burrow prediction #3249
base: beta
Are you sure you want to change the base?
Conversation
It is much more accurate
Added a polynomial fitter Added a simple matrix implementation
if you want to ask for help go to #coding on the skyhanni discord |
I have detected some issues with your pull request: Body issues: Title issues: Please fix these issues. For the correct format, refer to the pull request template. |
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/event/diana/SoopyGuessBurrow.kt
Conflicts have been resolved! 🎉 |
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
One or more Detekt Failures were detected:
|
Prevent reusing Diana Spade while on cooldown incorrectly invalidating previous data Updated ConfigFix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
havent tested ingame yet, just looked at the code
What
This PR adds a more accurate Diana burrow guesser.
This guesser converts the received particles into 3 2 dimensional polynomials with respect to an unknown variable t, then uses known information about the control points used to generate the locations to determine the exact position of the burrow.
Also adds two small utility classes which help fit a degree 3 polynomial to the known positions of the particles.
I tested on Hypixel during a Diana event and was unable to discover scenarios where this guesser was inaccurate
Changelog New Features