Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Gift Profit Tracker #3072

Open
wants to merge 43 commits into
base: beta
Choose a base branch
from
Open

Feature: Gift Profit Tracker #3072

wants to merge 43 commits into from

Conversation

DavidArthurCole
Copy link
Contributor

What

https://discord.com/channels/997079228510117908/1140705792937443448
Adds a profit tracker for opened gifts.

Technically has support for Party Gifts, but given the absurd price of those, and my lack of billions of coins to burn on getting chat patterns, this will solely track white/green/red gifts for now (unless the patterns are the same, I guess).

There are likely some items that are going to fail to map from the messages to the tracker. I had to add edge-case detection for Ice Runes, probably gonna be more... god bless beta testers.

Images

image

image

image

image

image

image

Changelog New Features

  • Added gift profit tracker. - Daveed
    • Does NOT auto track used gifts - see /shaddusedgifts.

Changelog Technical Details

  • Moved a couple existing gift-related resources to a new gifting package. - Daveed

@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Dec 16, 2024
@lunaynx
Copy link
Contributor

lunaynx commented Dec 16, 2024

Party gifts have a PARTY tier according to the official wiki, could add that next to SANTA, though I can't test either.

@DavidArthurCole
Copy link
Contributor Author

DavidArthurCole commented Dec 16, 2024 •
edited
Loading

Party gifts have a PARTY tier according to the official wiki, could add that next to SANTA, though I can't test either.

Next time alpha is open I'll make a concerted effort to open a couple and see if I can easily add them to this

@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 17, 2024
@hannibal002 hannibal002 changed the title Feature + Backend: Gift Profit Tracker Feature: Gift Profit Tracker Dec 17, 2024
@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Dec 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 4, 2025
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 25, 2025
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Feb 11, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002
Merge branch 'refs/heads/beta' into fork/DavidArthurCole/GiftTracker
d18795d 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/storage/ProfileSpecificStorage.kt
@hannibal002
merge conflict
20d69c5
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Feb 11, 2025
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

hannibal002
hannibal002 requested changes Feb 11, 2025
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well!
i dont like the non auto detection of gifts used. maybe we can later (outside this pr) add an option to track when the gift item moves in the air and read related from/to armor stands then?

src/main/java/at/hannibal2/skyhanni/features/gifting/UniqueGiftingOpportunitiesFeatures.kt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 Awaiting requested review from hannibal002

Assignees
No one assigned
Labels
Soon This Pull Request will be merged within the next couple of betas
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidArthurCole @lunaynx @hannibal002 @CalMWolfs