Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move container selector into a property #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

said-moj
Copy link

@said-moj said-moj commented Jul 1, 2019

  • Move container selector into a property so that it can overridden when needed without modifying the script
  • Make timeout warning message as properties so that they can be overridden without changing file

@hannalaakso
Copy link
Owner

Hi @said-moj

Thanks a lot for your PR. I've been working on updating the component to use GOV.UK Frontend and have moved the fork to use that instead of prototype kit. See https://github.com/hannalaakso/accessible-timeout-warning/commits/update-component

I'm going to merge those changes into master and then have a look at yours, they look broadly sensible to me 👍

You can find me on cross gov slack if you want to chat about any of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants