Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: clean up unused params. #860

Merged
merged 1 commit into from
Oct 20, 2023
Merged

pkg: clean up unused params. #860

merged 1 commit into from
Oct 20, 2023

Conversation

nodech
Copy link
Contributor

@nodech nodech commented Oct 16, 2023

Closes #603

@nodech nodech added quick review difficulty - easy patch Release version labels Oct 16, 2023
@nodech nodech added this to the hsd 7.0.0 milestone Oct 16, 2023
@nodech nodech added the cleanup improvement classification label Oct 16, 2023
@coveralls
Copy link

Coverage Status

coverage: 68.63% (-0.03%) from 68.658% when pulling 4354484 on nodech:cleanup-params into 5c287c9 on handshake-org:master.

rithvikvibhu
rithvikvibhu approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed none of these are used anywhere 👍

@nodech nodech merged commit 0690c6f into handshake-org:master Oct 20, 2023
6 checks passed
@nodech nodech deleted the cleanup-params branch October 20, 2023 08:49
@rithvikvibhu rithvikvibhu mentioned this pull request Oct 20, 2023
Open
@nodech nodech mentioned this pull request Nov 29, 2024
Merged
@nodech nodech mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithvikvibhu rithvikvibhu rithvikvibhu approved these changes

Assignees
No one assigned
Labels
cleanup improvement classification patch Release version quick review difficulty - easy
Projects
None yet
Milestone
hsd 7.0.0
Development

Successfully merging this pull request may close these issues.

Clean up unused network parameter: revocationDelay
3 participants
@nodech @coveralls @rithvikvibhu