Wallet: Add open/close and connect/disconnect events. #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WalletDB
open
does not guarantee that the connection will open, if it's in standalone mode it may fail. So having the connect method insideopen
w/o any guarantees leaves any logic depending on it break. So it's much better to totally remove the concept of connection from open.This changes several things:
connect
in the syncNode.wallet-migration-no-rescan
- that tells to ignore rescan request from the migration.Restructure the life-cycle methods for the walletdb.
open
event.connect
event.disconnect
eventclose
event.