Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up temporary files #374

Merged
merged 5 commits into from
Mar 17, 2024
Merged

Conversation

AdamOrmondroyd
Copy link
Collaborator

@AdamOrmondroyd AdamOrmondroyd commented Mar 16, 2024

Description

Pytest provides a handy tmp_path and apparently cleans up files placed in there.

Fixes #373

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cb60b9a) to head (023e52c).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #374   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         3032      3032           
=========================================
  Hits          3032      3032           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdamOrmondroyd AdamOrmondroyd marked this pull request as ready for review March 16, 2024 13:49
@AdamOrmondroyd
Copy link
Collaborator Author

There's something funky going on with macos and pytables, had to try three times to get the runner to complete. Whatever the problem is, it isn't one to fix here

Issue at PyTables/PyTables#1114

Copy link
Collaborator

@williamjameshandley williamjameshandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. Nice work.

@AdamOrmondroyd AdamOrmondroyd merged commit 80769c5 into handley-lab:master Mar 17, 2024
22 checks passed
@AdamOrmondroyd AdamOrmondroyd deleted the cleanup branch March 17, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-up of temporary files from tests
2 participants