Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create_transaction_category #73

Merged
merged 7 commits into from
Jan 27, 2024
Merged

Conversation

CalvinChanCan
Copy link
Contributor

@CalvinChanCan CalvinChanCan commented Jan 23, 2024

This PR does the following adds a new method create_transaction_category which creates new transaction categories

Notes:

  • Set default parameters for create_transaction_category based on the UI defaults
  • When entering non-emoji strings (i.e. "test"), a new transaction category would be created with the icon string "test")

Appreciate any feedback. Thanks!

@hammem hammem self-requested a review January 26, 2024 16:37
Copy link
Owner

@hammem hammem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CalvinChanCan ! One quick question in there about how to represent emojis. I wasn't sure what Monarch's API truly supports to reduce ambiguity.

Thanks for the bugfix as well. If you can, put those in a separate PR from features and I'll be faster about review to get those out to folks.

monarchmoney/monarchmoney.py Outdated Show resolved Hide resolved
@CalvinChanCan CalvinChanCan changed the title fix create_manual_account and add create_transaction_category feat: add create_transaction_category Jan 27, 2024
Copy link
Owner

@hammem hammem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@hammem hammem merged commit d0cee63 into hammem:main Jan 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants