Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#182 Supply Javadoc comments for MatcherAssert #263

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

#182 Supply Javadoc comments for MatcherAssert #263

wants to merge 4 commits into from

Conversation

prmr
Copy link

@prmr prmr commented Jun 20, 2019

#182 Supply Javadoc comments for all methods of MatcherAssert.

@tumbarumba
Copy link
Member

This seems like a nice improvement, but I'm afraid the Travis CI build failed. Can you fix that issue?

@nhojpatrick
Copy link
Member

@prmr want to get this merged, please can you rebase from master, as hamcrest-core and hamcrest-library have been refactored a lot and also deprecated, so that everything is just in hamcrest.

@nhojpatrick
Copy link
Member

Going to try and kick start hamcrest, so if you want to get it merged, please rebase from the branch v2.3-candidates.
Still trying to understand how has permissions to perform a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Awaiting rebase
Development

Successfully merging this pull request may close these issues.

3 participants