Skip to content

Commit

Permalink
chore: support go 1.19 (#125)
Browse files Browse the repository at this point in the history
  • Loading branch information
nrwiersma authored Aug 5, 2022
1 parent 6af1457 commit 17d37b2
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 19 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,31 @@ jobs:

strategy:
matrix:
go-version: [ 1.17, 1.18 ]
go-version: [ 1.18, 1.19 ]
runs-on: ubuntu-latest
env:
GOLANGCI_LINT_VERSION: v1.46.2
GOLANGCI_LINT_VERSION: v1.48.0

steps:
- name: Install Go
if: success()
uses: actions/setup-go@v2
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go-version }}

- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Cache Go modules
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
- name: Run linter
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
version: ${{ env.GOLANGCI_LINT_VERSION }}
args: --go ${{ matrix.go-version }}
Expand All @@ -43,7 +43,7 @@ jobs:
run: go test -covermode=count -coverprofile=coverage.out ./...

- name: Convert coverage.out to coverage.lcov
uses: jandelgado/gcov2lcov-action@v1.0.6
uses: jandelgado/gcov2lcov-action@v1
- name: Coveralls
uses: coverallsapp/[email protected]
with:
Expand Down
1 change: 1 addition & 0 deletions doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Package cmd implements cmd helpers.
This provides helpers on top of `github.com/urfave/cli`.
Example usage:
var c *cli.Context // Get this from your action
log, err := cmd.NewLogger(c)
Expand Down
24 changes: 12 additions & 12 deletions trace_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,46 +26,46 @@ func TestNewTracer(t *testing.T) {
wantErr: require.NoError,
},
{
name: "jaeger",
name: "jaeger",
exporter: "jaeger",
endpoint: "localhost:1234",
ratio: 1.0,
wantErr: require.NoError,
wantErr: require.NoError,
},
{
name: "jaeger invalid endpoint",
name: "jaeger invalid endpoint",
exporter: "jaeger",
endpoint: "localhost",
ratio: 1.0,
wantErr: require.Error,
wantErr: require.Error,
},
{
name: "zipkin",
name: "zipkin",
exporter: "zipkin",
endpoint: "http://localhost:1234/api/v2",
ratio: 1.0,
wantErr: require.NoError,
wantErr: require.NoError,
},
{
name: "unknown exporter",
name: "unknown exporter",
exporter: "some-exporter",
endpoint: "localhost:1234",
ratio: 1.0,
wantErr: require.Error,
wantErr: require.Error,
},
{
name: "ratio too low",
name: "ratio too low",
exporter: "jaeger",
endpoint: "localhost:1234",
ratio: -1.0,
wantErr: require.NoError,
wantErr: require.NoError,
},
{
name: "ratio too high",
name: "ratio too high",
exporter: "jaeger",
endpoint: "localhost:1234",
ratio: 2.0,
wantErr: require.NoError,
wantErr: require.NoError,
},
}

Expand Down

0 comments on commit 17d37b2

Please sign in to comment.