Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert theme to hugo module #477

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Convert theme to hugo module #477

merged 4 commits into from
Oct 31, 2023

Conversation

deining
Copy link
Contributor

@deining deining commented Jul 3, 2023

This PR converts the theme to a hugo module. In README.md, a section is added, explaining how to install the theme as hugo module. This PR also bumps some GitHb workflow dependencies to their latest version and converts some links from http to https protocol.

README.md Outdated Show resolved Hide resolved
exampleSite/go.mod Outdated Show resolved Hide resolved
@deining deining requested a review from henryiii July 4, 2023 07:59
@deining
Copy link
Contributor Author

deining commented Jul 17, 2023

Friendly ping 😄

@vinceyoumans
Copy link

another friendly ping. I would like to use this as a module.

Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready AFAICT.

@henryiii henryiii closed this Oct 30, 2023
@henryiii henryiii reopened this Oct 30, 2023
@henryiii
Copy link
Collaborator

We need to set up PR CI.

@henryiii henryiii closed this Oct 30, 2023
@henryiii henryiii reopened this Oct 30, 2023
@henryiii
Copy link
Collaborator

Done in #479.

@henryiii
Copy link
Collaborator

Something needs fixing with the paths.

@deining
Copy link
Contributor Author

deining commented Oct 31, 2023

Something needs fixing with the paths.

This is fixed with my latest commit. Once this PR with my latest commit is approved, checks will hopefully pass.

@deining deining requested a review from henryiii October 31, 2023 11:20
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@henryiii henryiii merged commit 62618bd into halogenica:master Oct 31, 2023
1 check passed
@henryiii
Copy link
Collaborator

Thanks!

@henryiii
Copy link
Collaborator

Also, it's always okay to ping me. ;)

@deining deining deleted the theme-as-hugo-module branch October 31, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants