Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated posts rendering to recommended method, using '.Site.RegularPages Type in .Site.Params.mainSections' #241

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ventz
Copy link

@ventz ventz commented Jan 14, 2019

Fix for issue: #240

Solution per official hugo recommendation for "posts" (or "post") type.

@ventz
Copy link
Author

ventz commented Jan 18, 2019

I have forked off beautifulhugo here: https://github.com/ventz/beautifulhugo
and I have applied this change!

pad92 added a commit to pad92/beautifulhugo that referenced this pull request Jan 29, 2019
@sagikazarmark
Copy link

sagikazarmark commented Feb 17, 2019

What about https://github.com/halogenica/beautifulhugo/blob/master/layouts/partials/header.html#L46 ?

What should be the default there? (Maybe use archetypes and a separate layout?)

Also, this is a major change, it might be a good idea to record it somewhere.

@ventz
Copy link
Author

ventz commented Feb 17, 2019

@sagikazarmark That's a good question. I think the .Type is a different built-in and still supported, but I am also not sure.

@sagikazarmark
Copy link

I rather meant the hardcoded "post" type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants