Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix details macro #130

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix details macro #130

merged 2 commits into from
Jan 29, 2025

Conversation

Haryto
Copy link
Contributor

@Haryto Haryto commented Jan 29, 2025

  • Refactor "DetailsMacro" to not use wiki template, but wrap contents in the "div". Arguments are stored as data attributes.
  • Process transclusions before links, in that case order matters. Otherwise they're converted as links.

* Refactor "DetailsMacro" to not use wiki template, but wrap contents in the "div". Arguments are stored as data attributes.
* Process transclusions before links, in that case order matters. Otherwise they're converted as links.
@Haryto Haryto requested a review from osnard January 29, 2025 11:19
@osnard osnard merged commit 5f9c92f into main Jan 29, 2025
1 check passed
@osnard osnard deleted the fix_details_macro branch January 29, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants